Repository navigation
Remove vulnerable coordinates from the remaining IT fixtures - #1724
Merged
Merged
Conversation
The fixture only needs a dependency whose POM declares a repository, so that list-repositories reports it as mirrored. maven-core 3.2.5 provided that through oss-parent in its POM chain and carries GHSA-2f88-5hg8-9x2x. The collector attaches descriptor repositories to the child nodes, so the mock dependency needs a transitive leaf for the repository to show up.
The test needs two artifacts that share artifactId and version under different groupIds; which artifacts they are does not matter, so serve them from the mrm mock repository instead of org.jdom:jdom 1.1.3, which carries an unfixable Dependabot alert (GHSA-2363-cqg2-863c).
batik-bridge only supplies the diamond of 'omitted for duplicate' nodes below maven-project's managed/conflict cases; 1.19 keeps that coverage and clears GHSA-rwqr-m72q-v6cm, GHSA-53jm-3hc9-fqqc and GHSA-gq5f-xv48-2365. Goldens regenerated under Maven 3.9.16 (identical on 3.9.0) and 4.0.0-rc-7.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clears the last five Dependabot alerts, all in IT fixtures, without changing what the tests cover.
list-repositoriesandcopy-dependencies-with-conflictnow depend on mock POMs served by mrm instead of maven-core 3.2.5 andorg.jdom:jdom(which has no fixed release). The mock dependency declares thesonatype-nexus-snapshotsrepository that previously came from maven-core's parent chain; it needs a child node because the collector attaches a POM's repositories to that POM's dependencies.tree-verbosebumps batik-bridge 1.7 → 1.19. Batik only contributed the "omitted for duplicate" diamond, which the new tree keeps; the managed-version and conflict cases come from maven-project 2.0.6.Verified:
mvn -P run-its verifyon the three ITs with a cleantarget→ passed under Maven 3.9.16 and 4.0.0-rc-7 (tree-verbosealso under 3.9.0).