Repository navigation
Restore MDEP-835 coverage in the tree IT - #1725
Merged
Merged
Conversation
…dler maven-core 3.9.x no longer depends on commons-lang3, so the tree IT lost the transitive copy that the optional direct one has to win over. A mock dependency served by mrm brings it back without adding a real coordinate for Dependabot to track.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #1722 and #1723. maven-core 3.9.x no longer depends on commons-lang3, so after #1723 the
treeIT no longer covered a direct optional dependency winning over a transitive compile one (MDEP-835). A mock dependency insrc/it/mrmnow brings commons-lang3 in transitively; being a mock, it adds no real coordinate for Dependabot to track. The PR also removes theHEADbranch from the test server inTestGetMojo, which the resolver never reaches.Verified:
tree,tree-scopeandtree-verboseITs → passed under Maven 3.9.16 and 4.0.0-rc-7;TestGetMojopasses with and without-Djava.net.preferIPv6Addresses=true.