Repository navigation
Remove JUL handlers Maven installed when closing the embedded executor - #67
Closed
slachiewicz wants to merge 1 commit into
Closed
slachiewicz wants to merge 1 commit into
slachiewicz wants to merge 1 commit into
Conversation
Maven 4 puts an SLF4JBridgeHandler on the JVM-global JUL root logger. Closing the executor closes its class realm, so the next JUL record logged in the JVM (JUnit's TempDir message) failed with NoClassDefFoundError: org/slf4j/spi/LocationAwareLogger.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Maven 4 installs an SLF4JBridgeHandler on the JVM-global JUL root logger; closing the embedded executor closes the realm that handler was loaded from, so the next JUL record in the test JVM (JUnit's TempDir message) failed with NoClassDefFoundError for org.slf4j.spi.LocationAwareLogger. The executor now removes the handlers loaded by its own realms before closing them, which also unblocks #60 and #63.
Verified: new EmbeddedMavenExecutorLoggingTest fails on main for Maven 4 (leaked SLF4JBridgeHandler) and passes with the fix; I could not reproduce the Windows JDK 26 cell locally.