Repository navigation
[HOLD until maven-sources#57 swap] Switch default-branch metadata to Maven 3 (.asf.yaml + README) - #412
[HOLD until maven-sources#57 swap] Switch default-branch metadata to Maven 3 (.asf.yaml + README)#412ascheman wants to merge 3 commits into
Conversation
Make .asf.yaml identical to the current master (branch-swapped to maven-filtering-4.x) and repoint the README CI/badge/tree links, for the default-branch swap tracked in apache/maven-sources#57. No github.default_branch is added (INFRA sets the default as part of the renames); also drops a maven-filtering-3.x-only notifications.jira_options to match master. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01SJcgjSha5PNT8WFBMC1v5b
|
You also take care about
are taken from default branch |
GitHub reads .github/ from the default branch, so moving the default to maven-filtering-3.x would silently drop the issue templates and the scheduled stale workflow that master provides. Add them on this branch. Line-specific .github config (dependabot, maven-verify CI) stays the Maven 3 line's, as that is what the new master should run. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01SJcgjSha5PNT8WFBMC1v5b
Good catch, thanks @slawekjaranowski — you're right. On maven-filtering the |
This comment was marked as outdated.
This comment was marked as outdated.
|
Did you test how release drafter will generate drafts after change ... By the way action is disabled ... https://github.com/apache/maven-filtering/actions/workflows/release-drafter.yml |
Take master's current pull_request_template.md (the -3.x branch carried an older variant) and the release-drafter workflow (whose branch filter must point at the new master). Line-specific .github config (dependabot, the release-drafter config, the maven-verify CI) stays the Maven 3 line's. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01SJcgjSha5PNT8WFBMC1v5b
5a5040e to
77c37a8
Compare
@slawekjaranowski Not disabled by this PR — Release Drafter is already That makes the branch-filter alignment I'd put in here runtime-moot, so I've reverted it: this PR now leaves
It generates nothing today (disabled), and the swap doesn't change that. If the Maven 3 line ever re-enables it, fixing the filter is a separate, line-local step for whoever turns it back on. |
Part of apache/maven-sources#57 (switching plugin default branches back to Maven 3, cf. Plan / runbook).
⛔ DO NOT MERGE before the swap. This PR should be merged immediately around the branch rename on 2026-10-18 (coordinated with INFRA). Please review/approve by 2026-10-16 so it can be merged right at the switch.
What changes
.asf.yamlThis makes this branch's
.asf.yamlidentical to the currentmaster's, with the only intended difference being the protected-branch name swap (maven-filtering-3.x→maven-filtering-4.x).Why that's needed: ASF asfyaml only honours the default branch's
.asf.yaml. Several settings therefore live only on today'smasterand are absent on this (-3.x) branch, which is dormant until the swap. Whenmaven-filtering-3.xbecomes the new defaultmaster, it must carry them or they'd be silently dropped. Here that means addingprotected_branches(master+maven-filtering-4.x),pull_requests.del_branch_on_mergeandfeatures.issues.No
default_branchis added — the currentmasterhas none, and the default pointer is set back tomasterby INFRA as part of the renames, not via.asf.yaml.To keep the new
master's.asf.yamlbyte-identical to today'smaster(so the swap introduces no silent config drift), this PR also removes one branch-only line that exists onmaven-filtering-3.xbut not onmaster:notifications.jira_options: link label commentRationale: it is not on
master, and with the Maven JIRA → GitHub-issues migration it is effectively vestigial. If you want it kept on the Maven 3 line, say so in review and we'll restore it.(In sibling repos the same alignment also drops a
-3.x-onlyautolink_jirawheremasterhas none — not applicable here; flagged for consistency.)README.mdRepoints the Jenkins / badge / tree links to the post-swap scheme: the Maven 3 line →
job/master, the Maven 4 line →job/maven-filtering-4.x(+tree/maven-filtering-4.x). The reproducible-central/master/paths (a different repo) are left untouched; the Maven Centralfilter=3*stays on the Maven 3 block..github/.github/is read from the default branch, so the swap must carry it or it would silently drop. This PR:maven-filtering-3.xwas missing vsmaster: the.github/ISSUE_TEMPLATE/forms and the scheduled.github/workflows/stale.yml(otherwise issue templates and the stale bot would stop working after the swap);master's current version:pull_request_template.md(the-3.xone was an older variant);.github/dependabot.yml, the release-drafter config, the release-drafter workflow, and themaven-verifyCI workflow. (The release-drafter workflow isdisabled_manuallyon the repo, so itson.push.branchesfilter never runs — aligning it would be runtime-moot, so it stays the Maven 3 line's own. Thanks @slawekjaranowski.)(Flagged for review — thanks @slawekjaranowski for raising this: if any of the repo-wide takeovers isn't wanted, say so.)
Short inconsistency window after merge
These URLs only become correct once the rename completes and Jenkins re-discovers the branches:
job/masteris today still the Maven 4 job (becomes Maven 3 after the rename);job/maven-filtering-4.xandtree/maven-filtering-4.xdon't exist yet (created by themaster→maven-filtering-4.xrename);So between merge and the completed rename (+ CI sync) there is a short window of dead badges / links pointing at not-yet-existing branches. This is expected and resolves once the 2026-10-18 swap finishes.