Repository navigation
Accept an slf4j Logger in DefaultReleaseManagerListener - #1515
Closed
slachiewicz wants to merge 2 commits into
Closed
slachiewicz wants to merge 2 commits into
slachiewicz wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DefaultReleaseManagerListeneronly accepts the Maven 3 pluginLog, which the Maven 4 API line does not have. This adds constructors that take an slf4jLogger(slf4j-api is already a dependency of maven-release-manager) and deprecates theLogones; the messages are unchanged.maven-release-plugin still uses the deprecated constructors: moving its mojos to an slf4j logger changes how their output is routed, so that is a separate change.
Part of apache/maven#13309.