Repository navigation
Rewrite POM versions through Pom* views over the DomTrip model - #1518
Closed
slachiewicz wants to merge 2 commits into
Closed
slachiewicz wants to merge 2 commits into
slachiewicz wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AbstractRewritePomsPhase.transformDocumentwalked the DomTrip model through the Maven 3 model classes and converted each list withtoMavenCoordinates. It now works on small read-through views (PomModel,PomModelBase,PomBuild,PomBuildBase,PomPlugin,PomProfile), with the method names the Maven 4 port uses, so the port keeps this method and dropsextends Modelfrom the DomTrip classes instead. The four copies of the plugin and plugin-management loops become onerewriteBuildPlugins; the edit order is unchanged.The DomTrip classes cannot implement the views directly while they extend the Maven 3 model (
getDependencies()would need two return types), soModelPomViewswraps the model.ModelETL.getPomModel()defaults to that view overgetModel(), so anyModelETLimplementation keeps working. The new types are@since 3.4, like the DomTrip classes.Part of apache/maven#13309.
Verified:
mvn verify→ manager module 773 tests (4 new), 0 failures; the expected-POM rewrite tests pass unchanged.