In failed build limit reactor summary to only failed modules - improvements

[slawekjaranowski]

What changed:

• Replace isExecutionRoot skip logic with lastWasSkipped flag in logReactorSummary
• Print ... before first visible entry and after last skipped group
• Add testSessionEndedFailureMultimoduleWithSeparatedFailures test
• Based on In failed build limit reactor summary to only failed modules #12330 / commit 794866c

Following this checklist to help us incorporate your
contribution quickly and easily:

• Your pull request should address just one issue, without pulling in other changes.
• Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
• Each commit in the pull request should have a meaningful subject line and body.
  Note that commits might be squashed by a maintainer on merge.
• Write unit tests that match behavioral changes, where the tests fail if the changes to the runtime are not applied.
  This may not always be possible but is a best-practice.
• Run mvn verify to make sure basic checks pass.
  A more thorough check will be performed on your pull request automatically.
• You have run the Core IT successfully.

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

• I hereby declare this contribution to be licenced under the Apache License Version 2.0, January 2004
• In any other case, please file an Apache Individual Contributor License Agreement.

[gnodet]

Review: In failed build limit reactor summary to only failed modules - improvements

Verdict: APPROVE ✅

This PR fixes a real bug in the reactor summary ellipsis logic from PR #12330. The original code used isExecutionRoot() to decide when to print ... before skipped modules, which only worked when the root project was the one being skipped — if two failures were separated by successful modules, no ... appeared between them. The new lastWasSkipped flag correctly tracks transitions between skipped and shown projects, printing ... at every transition boundary.

What I verified

• Multiple separated failures: ... appears between each group ✅ (new test case)
• Single failure at start: no leading ..., trailing ... for remaining skipped ✅
• Single failure in middle: ... before and after ✅ (existing test, still passes)
• All failures: no ... at all ✅
• Successful build: no ... ✅

Test changes

• MockitoSession addition enables strict stubbing detection — good practice
• lenient() on getGroupId()/getArtifactId() is correct since only getName()/getVersion() are used in summary lines
• Removal of isExecutionRoot() stub is correct — production code no longer calls it
• Trailing ... condition changed from result.hasExceptions() to lastWasSkipped, which is more precise (only prints ... when there actually were trailing skipped modules)
• New test testSessionEndedFailureMultimoduleWithSeparatedFailures covers the exact scenario this fix addresses

Clean, well-focused improvement. LGTM.

---

This review was generated by an AI agent and may contain inaccuracies. Please verify all suggestions before applying.

Claude Code on behalf of Guillaume Nodet

[slawekjaranowski]

suppressed by

• Fixes #13135: ensure completeness of the reactor summary, privilege f… #13173
  status of all modules are printed

so can be skipped from change log