Skip to content

Fixes #13135: address review on reactor summary (UNKNOWN group, local StringBuilder) [master] #13182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gnodet merged 1 commit into from
Sep 18, 2026
Merged

Fixes #13135: address review on reactor summary (UNKNOWN group, local StringBuilder) [master] #13182

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions compat/maven-embedder/src/main/java/org/apache/maven/cli/event/ExecutionEventLogger.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -222,20 +222,20 @@ private void logReactorSummary(MavenSession session) {
group = 0;
} else {
statusMessage = unknownMessage;
group = 0;
group = 2;
}
entries.add(new ReactorSummaryEntry(project, buildSummary, group, statusMessage));
}

ReactorSummaryRequest request = new ReactorSummaryRequest(entries, new StringBuilder(128), isSingleVersion);
ReactorSummaryRequest request = new ReactorSummaryRequest(entries, isSingleVersion);

logReactorSummaryGroup(request, 0);
logReactorSummaryGroup(request, 1);
logReactorSummaryGroup(request, 2);
}

private void logReactorSummaryGroup(ReactorSummaryRequest request, int group) {
StringBuilder buffer = request.buffer();
StringBuilder buffer = new StringBuilder(128);

for (ReactorSummaryEntry entry : request.entries()) {
if (entry.group() != group) {
Expand Down Expand Up @@ -271,8 +271,7 @@ private void logReactorSummaryGroup(ReactorSummaryRequest request, int group) {
}
}

private record ReactorSummaryRequest(
List<ReactorSummaryEntry> entries, StringBuilder buffer, boolean isSingleVersion) {}
private record ReactorSummaryRequest(List<ReactorSummaryEntry> entries, boolean isSingleVersion) {}

private record ReactorSummaryEntry(
MavenProject project, BuildSummary buildSummary, int group, String statusMessage) {}
Expand Down
9 changes: 4 additions & 5 deletions impl/maven-cli/src/main/java/org/apache/maven/cling/event/ExecutionEventLogger.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -227,20 +227,20 @@ private void logReactorSummary(MavenSession session) {
group = 0;
} else {
statusMessage = unknownMessage;
group = 0;
group = 2;
}
entries.add(new ReactorSummaryEntry(project, buildSummary, group, statusMessage));
}

ReactorSummaryRequest request = new ReactorSummaryRequest(entries, new StringBuilder(128), isSingleVersion);
ReactorSummaryRequest request = new ReactorSummaryRequest(entries, isSingleVersion);

logReactorSummaryGroup(request, 0);
logReactorSummaryGroup(request, 1);
logReactorSummaryGroup(request, 2);
}

private void logReactorSummaryGroup(ReactorSummaryRequest request, int group) {
StringBuilder buffer = request.buffer();
StringBuilder buffer = new StringBuilder(128);

for (ReactorSummaryEntry entry : request.entries()) {
if (entry.group() != group) {
Expand Down Expand Up @@ -276,8 +276,7 @@ private void logReactorSummaryGroup(ReactorSummaryRequest request, int group) {
}
}

private record ReactorSummaryRequest(
List<ReactorSummaryEntry> entries, StringBuilder buffer, boolean isSingleVersion) {}
private record ReactorSummaryRequest(List<ReactorSummaryEntry> entries, boolean isSingleVersion) {}

private record ReactorSummaryEntry(
MavenProject project, BuildSummary buildSummary, int group, String statusMessage) {}
Expand Down
Loading