Keep the basedir unset for a parent served from the project-local repository - #13213
Merged
Merged
Conversation
…ository The ReactorReader also answers for POMs it stored in .mvn/target/project-local-repo, so a parent installed by an earlier build resolves from the WorkspaceRepository and DefaultProjectBuilder treated it as a checkout, giving it a basedir inside the repository. Only a POM of a project in this session is a checkout; anything else the workspace serves is built like a repository artifact, with the file unset as on Maven 3. Closes #13211
slachiewicz
marked this pull request as ready for review
September 20, 2026 20:32
gnodet
approved these changes
Sep 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #13211. Forward-port of #13212, which has the description, including the two tests in
WorkspaceParentProjectBuilderTest.Verified: maven-core unit tests on master → 700 run, 0 failures. The maven-site-plugin IT check (62 passed) ran on the
maven-4.0.xbuild.