Skip to content

drivers/mtd/filemtd: open the backing file O_RDWR #20001

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AlmAck wants to merge 1 commit into
base: master
Choose a base branch
from
+1 −1
Open

drivers/mtd/filemtd: open the backing file O_RDWR #20001

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion drivers/mtd/filemtd.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -507,7 +507,7 @@
{
FAR struct partition_info_s *info =
(FAR struct partition_info_s *)arg;
if (info != NULL)

Check failure on line 510 in drivers/mtd/filemtd.c

View workflow job for this annotation

GitHub Actions / check 

Missing blank line after declarations
{
info->numsectors = priv->nblocks *
priv->erasesize / priv->blocksize;
Expand All @@ -530,7 +530,7 @@
case MTDIOC_ERASESTATE:
{
FAR uint8_t *result = (FAR uint8_t *)arg;
*result = CONFIG_FILEMTD_ERASESTATE;

Check failure on line 533 in drivers/mtd/filemtd.c

View workflow job for this annotation

GitHub Actions / check 

Missing blank line after declarations

ret = OK;
}
Expand Down Expand Up @@ -580,7 +580,7 @@
/* Try to erase the entire device, before register */

FAR struct file_dev_s *fdev = (FAR struct file_dev_s *)mtd;
mtd->erase(mtd, offset / erasesize, fdev->nblocks);

Check failure on line 583 in drivers/mtd/filemtd.c

View workflow job for this annotation

GitHub Actions / check 

Missing blank line after declarations
}

ret = mtdconfig_register_by_path(mtd, devname);
Expand Down Expand Up @@ -698,14 +698,14 @@

switch (cmd)
{
/* Command: LOOPIOC_SETUP

Check failure on line 701 in drivers/mtd/filemtd.c

View workflow job for this annotation

GitHub Actions / check 

Bad comment alignment
* Description: Setup the loop device

Check failure on line 702 in drivers/mtd/filemtd.c

View workflow job for this annotation

GitHub Actions / check 

Bad comment block alignment
* Argument: A pointer to a read-only instance of struct losetup_s.

Check failure on line 703 in drivers/mtd/filemtd.c

View workflow job for this annotation

GitHub Actions / check 

Bad comment block alignment
* Dependencies: The loop device must be enabled (CONFIG_MTD_LOOP=y)

Check failure on line 704 in drivers/mtd/filemtd.c

View workflow job for this annotation

GitHub Actions / check 

Bad comment block alignment
*/

Check failure on line 705 in drivers/mtd/filemtd.c

View workflow job for this annotation

GitHub Actions / check 

Bad comment block alignment

case MTD_LOOPIOC_SETUP:

Check failure on line 707 in drivers/mtd/filemtd.c

View workflow job for this annotation

GitHub Actions / check 

Bad alignment
{

Check failure on line 708 in drivers/mtd/filemtd.c

View workflow job for this annotation

GitHub Actions / check 

Bad left brace alignment
FAR struct mtd_losetup_s *setup =
(FAR struct mtd_losetup_s *)((uintptr_t)arg);

Expand Down Expand Up @@ -813,7 +813,7 @@

/* Set the file open mode. */

mode = O_RDONLY | O_WRONLY | O_CLOEXEC;
mode = O_RDWR | O_CLOEXEC;

/* Try to open the file. NOTE that block devices will use a character
* driver proxy.
Expand Down
Loading