tools/export: prefix each linker script in toolchain.cmake - #20022
Open
r3wretrhy wants to merge 1 commit into
Open
tools/export: prefix each linker script in toolchain.cmake#20022r3wretrhy wants to merge 1 commit into
r3wretrhy wants to merge 1 commit into
Conversation
r3wretrhy
force-pushed
the
tools-export-prefix-ldscripts
branch
2 times, most recently
from
August 31, 2026 09:00
c8654b7 to
4355688
Compare
1 task
xiaoxiang781216
approved these changes
Aug 31, 2026
make export writes several names into LDNAME for boards that use more than one linker script. The exported toolchain.cmake only prefixed the first file, so ld searched for the rest in the application build directory. Normalize NUTTX_PATH so the generated -T arguments do not keep the scripts/../scripts form. Fixes apache#19820. Signed-off-by: Zhaoqi Xu <lzy00419@outlook.com>
r3wretrhy
force-pushed
the
tools-export-prefix-ldscripts
branch
from
August 31, 2026 09:22
4355688 to
e84a3b7
Compare
xiaoxiang781216
approved these changes
Aug 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tools/export: prefix each linker script in toolchain.cmake.
Summary
Impact
Testing
I confirm that changes are verified on local setup and works as intended:
Testing logs before change:
OLD_RULE=-T/tmp/nuttx-export-13.0.0/scripts/../scripts/esp32s3_peripherals.ld esp32s3_rom_aliases.ld flat_memory.ld esp32s3_sections.ldTesting logs after change:
NUTTX_PATH=/tmp/nuttx-export-13.0.0 NEW_RULE=-T/tmp/nuttx-export-13.0.0/scripts/esp32s3_peripherals.ld -T/tmp/nuttx-export-13.0.0/scripts/esp32s3_rom_aliases.ld -T/tmp/nuttx-export-13.0.0/scripts/flat_memory.ld -T/tmp/nuttx-export-13.0.0/scripts/esp32s3_sections.ld EXPORT_LDNAME_OKPR verification Self-Check