ORC-2192: [C++] Reject invalid string length in StringDirectColumnReader#2673
Open
dongjoon-hyun wants to merge 1 commit into
Open
ORC-2192: [C++] Reject invalid string length in StringDirectColumnReader#2673dongjoon-hyun wants to merge 1 commit into
dongjoon-hyun wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR adds validation to
StringDirectColumnReader::computeSizein the C++ reader so a negative or overflowing string length throwsParseErrorbefore any blob is allocated. Both callers (nextandskip) are covered, and sincebuildReaderroutes all direct-encoded string-family types to this reader, the single guard protectsBINARY/CHAR/STRING/VARCHAR/GEOMETRY/GEOGRAPHY.Why are the changes needed?
The LENGTH stream is decoded as unsigned RLE, so a malformed file can encode a varint
>= 2^63that becomes a negativeint64_t. Cast tosize_t, this triggers a hugeblob.resize()and an out-of-bounds pointer walk. This restores parity with the Java reader, which already guards this path inBytesColumnVectorUtil.commonReadByteArrays.How was this patch tested?
Added
TestColumnReader.testStringDirectNegativeLength, which feeds a crafted LENGTH stream decoding toINT64_MINand assertsParseErroris thrown.Was this patch authored or co-authored using generative AI tooling?
Generated-by: Claude Fable 5