HDDS-15757. Streaming Write also commit PutBlock at the time of closing#10694
Open
amaliujia wants to merge 3 commits into
Open
HDDS-15757. Streaming Write also commit PutBlock at the time of closing#10694amaliujia wants to merge 3 commits into
amaliujia wants to merge 3 commits into
Conversation
amaliujia
force-pushed
the
streaming_putblock_dn
branch
from
b8e4e3e to
4902773
Compare
amaliujia
changed the title
amaliujia
changed the title
amaliujia
changed the title
amaliujia
changed the title
Contributor
Author
|
R: @szetszwo |
yandrey321
reviewed
Jul 9, 2026
|
|
||
| public ContainerCommandRequestProto getPutBlockRequest() { | ||
| return Objects.requireNonNull(putBlockRequest.get(), | ||
| () -> "putBlockRequest == null, " + this); |
Contributor
There was a problem hiding this comment.
do we have any meaningful toString() that would trace the state of the object in '+ this'?
Contributor
|
Contributor
Author
|
@yandrey321 you may find motivations from comments under https://issues.apache.org/jira/browse/HDDS-15463 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
A new config (
hdds.datanode.datastream.putblock.enabled) is introduced to control the behavior of PutBlock:The future PR will be the client side change that should no longer send PutBlock as a separate Raft request.
This PR is assisted by Cursor ai.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-15792
How was this patch tested?
Unit test.