[improvement] Guard schema changes against live Global Index references (#9419) - #9438
Open
zhang-arvin wants to merge 1 commit into
Open
[improvement] Guard schema changes against live Global Index references (#9419)#9438zhang-arvin wants to merge 1 commit into
zhang-arvin wants to merge 1 commit into
Conversation
…es (apache#9419) Signed-off-by: zhang-arvin <arvin.zhang@htx-inc.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This PR adds a guard in
SchemaManagerthat prevents schema changes (specificallyDropColumn) from being applied when the column is referenced by a live Global Index.Problem
Currently, schema changes like dropping a column can proceed even when Global Indexes defined on that column exist. This leads to inconsistent index state and potential data corruption.
Solution
Added
checkGlobalIndexConflictsmethod inSchemaManagerthat:global-indexentries to extract indexed column namesDropColumntargets a Global Index columnUnsupportedOperationExceptionwith a clear message directing users to drop the Global Index firstTesting
mvn compile -pl paimon-core -am -DskipTestspassesRelated Issue
Closes #9419