[core] Harden and slim FM index storage - #9450
Merged
Merged
Conversation
utafrali
reviewed
Aug 28, 2026
utafrali
left a comment
There was a problem hiding this comment.
The PR is well-structured and the test coverage for the new paths is solid. The one blocking concern is the undocumented format break: switching from CRC32C to IEEE CRC32 without incrementing VERSION makes old and new files silently incompatible, which is fixable with a single constant change and a clear error message in the footer reader.
leaves12138
approved these changes
Aug 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Storage impact
For uncompressed or hard-to-compress text, the index no longer carries roughly the full source string bytes plus 4 bytes per row and page metadata. The golden fixture shrinks from 1,926 to 1,860 bytes for 14 source bytes across four rows.
Tests
mvn -pl paimon-common -DwildcardSuites=none -Dtest=FMGlobalIndexTest,FMIndexSuffixArrayTest test