[ISSUE #299]polish(example) remove selection count - #310
Conversation
|
close #299 |
RockteMQ-AI
left a comment
There was a problem hiding this comment.
Review: Approved ✅
PR: #310 — Fix example
Type: Bug fix (1 file, +3/-3)
Assessment
Fixes example code. Minimal change.
Verdict
✅ Simple fix.
🤖 Automated review by oss-sentinel-ai
RockteMQ-AI
left a comment
There was a problem hiding this comment.
LGTM — Clean removal of unused count(SelectAction) overload, resetOffsetHandler field, and stale example.
Note: removing GroupedStream.count(SelectAction) is a breaking API change for downstream users. Consider mentioning this in release notes.
Automated review by github-manager-bot
RockteMQ-AI
left a comment
There was a problem hiding this comment.
Summary
Code cleanup — removes unused API surface and dead code:
GroupedStream.count(SelectAction)overload — theselectActionparameter was accepted but never used in the aggregation logic (always justagg + 1)MessageQueueListenerWrapper.resetOffsetHandler— unused field and setter- Stale
Demo.javaexample
Findings
- [Info] Removing the
count(SelectAction)overload is a minor breaking API change for any external users ofGroupedStream. Since the parameter was silently ignored, this is the right call — but worth noting in release notes.
LGTM.
|
Issue Evaluation Category: This issue references #299 and proposes polishing examples by removing selection count. Opened August 2023, no activity since. Assessment:
Recommendation: If still relevant, please provide:
If no activity occurs, this issue may be closed as stale. Automated evaluation by @RockteMQ-AI |
No description provided.