fix SolrStream long-running timeouts#4622
Closed
iprithv wants to merge 1 commit into
Closed
Conversation
Contributor
|
The JIRA issue showed someone else was picking this up; see #4626 . I like that solution better as I don't think there should be a general request timeout. There wasn't one in the past (for Apache HttpClient based SolrClient). |
Author
|
Thanks @dsmiley. I targeted change to a narrower attempt scoped to SolrClientCache, but agree the global default fix is the right direction (and matches the pre-Http2 behavior). I'll close this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
after the switch to SolrClientCache (around 9.4), SolrStream (and other TupleStreams) started using clients with a hard 60-second floor for timeouts. This caused TimeoutException: Total timeout 60000 ms elapsed on long-running streaming responses (/export, slow analytic streams, etc.).
The header-wait path (listener.get(idleTimeoutMillis, ...)) and per-chunk idle also used the low timeout, so even slow-starting or slowly emitting streams would fail.
SOLR-17433