Skip to content

feat(computing-unit-managing-service): say how to free a slot when the CU quota is reached - #8772

Merged
Xiao-zhen-Liu merged 4 commits into
apache:mainfrom
sshiv012:sshiv012/tex-86-cu-quota-message
Nov 7, 2026
Merged

Xiao-zhen-Liu merged 4 commits into
apache:mainfrom
sshiv012:sshiv012/tex-86-cu-quota-message

Conversation

@sshiv012

@sshiv012 sshiv012 commented Sep 30, 2026 •

Copy link
Copy Markdown
Contributor

What changes were proposed in this PR?

When a user hits the computing unit limit, the error only said "You may only have N computing-unit(s) running at the same time". It now adds what to do: "Reuse a running computing unit, terminate a cloud unit, or disconnect a local unit you no longer need." Local units count toward the limit too, and the UI removes them with "Disconnect", which calls the same terminate endpoint and frees the slot.

Any related issues, documentation, discussions?

Part of #8736. Split out of #8737.

How was this PR tested?

Updated ComputingUnitManagingServiceExceptionSpec.

sbt "ComputingUnitManagingService/testOnly org.apache.texera.service.util.ComputingUnitManagingServiceExceptionSpec" "ComputingUnitManagingService/scalafmtCheck" "ComputingUnitManagingService/Test/scalafmtCheck"

There's no screenshot because this error only appears on a Kubernetes deployment, and I tested on a local install.

Was this PR authored or co-authored using generative AI tooling?

Generated-by: Claude Code (Claude Opus 5.5)

…e CU quota is reached

The quota error only said "You may only have N computing-unit(s)
running at the same time". It now adds: "Reuse one of your running
computing units, or terminate one you no longer need."

Refs TEX-86

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
(cherry picked from commit 58999cc)
@github-actions github-actions Bot added the platform Non-amber Scala service paths label Sep 30, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Automated Reviewer Suggestions

Based on the git blame history of the changed files, we recommend the following reviewers:

  • Contributors with relevant context: @aglinxinyuan, @mengw15
    You can notify them by mentioning @aglinxinyuan, @mengw15 in a comment.

@codecov-commenter

codecov-commenter commented Sep 30, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.17%. Comparing base (07fffb3) to head (39dd0ad).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #8772      +/-   ##
============================================
- Coverage     92.17%   92.17%   -0.01%     
- Complexity     4987     4988       +1     
============================================
  Files          1284     1284              
  Lines         55605    55599       -6     
  Branches       7120     7120              
============================================
- Hits          51255    51249       -6     
  Misses         2591     2591              
  Partials       1759     1759              
Flag Coverage Δ *Carryforward flag
access-control-service 77.44% <ø> (ø)
agent-service 99.54% <ø> (-0.01%) ⬇️ Carriedforward from 241c98a
amber 86.85% <ø> (+<0.01%) ⬆️ Carriedforward from 241c98a
computing-unit-managing-service 64.05% <100.00%> (+0.02%) ⬆️
config-service 87.61% <ø> (ø)
file-service 82.29% <ø> (ø)
frontend 96.47% <ø> (-0.01%) ⬇️ Carriedforward from 241c98a
notebook-migration-service 83.77% <ø> (ø)
pyamber 98.54% <ø> (ø) Carriedforward from 241c98a
workflow-compiling-service 77.95% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sshiv012

sshiv012 commented Oct 2, 2026

Copy link
Copy Markdown
Contributor Author

/request-review @Xiao-zhen-Liu

@github-actions
github-actions Bot requested a review from Xiao-zhen-Liu October 2, 2026 20:28
…or each unit type

Local units count toward the running-unit limit too, and the UI removes
them with "Disconnect" (the same terminate call, which frees the slot).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@sshiv012

sshiv012 commented Oct 8, 2026

Copy link
Copy Markdown
Contributor Author

Fixed: the hint now says which action frees a slot for cloud and local units.

…ently and name Kubernetes units

"computing-unit(s)" becomes "computing unit(s)" to match the rest of
the message, and "cloud unit" becomes "Kubernetes unit", which is what
the UI calls them.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@Xiao-zhen-Liu
Xiao-zhen-Liu added this pull request to the merge queue Oct 15, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to no response for status checks Oct 15, 2026
@Xiao-zhen-Liu
Xiao-zhen-Liu added this pull request to the merge queue Oct 21, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to no response for status checks Oct 21, 2026
@Xiao-zhen-Liu
Xiao-zhen-Liu added this pull request to the merge queue Oct 22, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to no response for status checks Oct 22, 2026
@sshiv012

sshiv012 commented Nov 3, 2026

Copy link
Copy Markdown
Contributor Author

@Xiao-zhen-Liu can you add this and #8770 and #8771 to merge queue again?

@Xiao-zhen-Liu
Xiao-zhen-Liu added this pull request to the merge queue Nov 6, 2026
Merged via the queue into apache:main with commit 97a70a5 Nov 7, 2026
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

platform Non-amber Scala service paths

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants