Repository navigation
refactor(frontend): share dataset and model resource UI - #9522
Open
aglinxinyuan wants to merge 3 commits into
Open
aglinxinyuan wants to merge 3 commits into
aglinxinyuan wants to merge 3 commits into
Conversation
Contributor
Automated Reviewer SuggestionsBased on the
|
aglinxinyuan
added a commit
to aglinxinyuan/texera
that referenced
this pull request
Nov 17, 2026
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9522 +/- ##
============================================
+ Coverage 91.60% 91.62% +0.02%
+ Complexity 5053 4962 -91
============================================
Files 1285 1285
Lines 57136 56558 -578
Branches 7442 7368 -74
============================================
- Hits 52337 51823 -514
+ Misses 2915 2893 -22
+ Partials 1884 1842 -42
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this PR?
Extracts shared stylesheets, Settings-tab cards, overview statistics projection, Formly field builders, upload-tuning loaders, and test fixtures across dataset and model management UI components with no user-facing behavior change:
_resource-detail-shared.scss,overviewStatistics(@for), single-icon binding &createFiletreeFixtureResourceDetailSettingsComponent(div[texeraResourceDetailSettings]),saveTextSettingresourceNameAndDescriptionFields,contributorInput,createFormlyModalFixtureloadUploadSettings, sharedstageFile/mount/expectAbortRequesttest helpersAny related issues, documentation, discussions?
Closes #9520.
How was this PR tested?
Ran in
frontend/on63e9447924:yarn format:ci— passedyarn tsc --noEmit -p src/tsconfig.app.json— passedyarn tsc --noEmit -p src/tsconfig.spec.json— passedyarn test:ci—254 passed (254)files,7290 passed | 1 skipped (7291)testsyarn ng run gui:test-browser --watch=false --progress=false—3 passed (3)files,23 passed (23)tests in Chromiumyarn build:ci --skip-nx-cache— production build succeeded1280x980) againstng servewith stubbed/api/**: navigated to/user/dataset/1(Data Card,Versions & Files,Settings) and/user/model/1(Model Card,Settings) before and after refactoring to verify identical layout and controls.Visual comparison (
1280x980desktop)main)Was this PR authored or co-authored using generative AI tooling?
Generated-by: Antigravity IDE (Gemini 3.8 Flash)