Skip to content

refactor(frontend): share dataset and model resource UI - #9522

Open
aglinxinyuan wants to merge 3 commits into
apache:mainfrom
aglinxinyuan:refactor/resource-detail-creator-ui
Open

aglinxinyuan wants to merge 3 commits into
apache:mainfrom
aglinxinyuan:refactor/resource-detail-creator-ui

Conversation

@aglinxinyuan

@aglinxinyuan aglinxinyuan commented Nov 17, 2026 •

Copy link
Copy Markdown
Contributor

What changes were proposed in this PR?

Extracts shared stylesheets, Settings-tab cards, overview statistics projection, Formly field builders, upload-tuning loaders, and test fixtures across dataset and model management UI components with no user-facing behavior change:

Area Shared abstraction Consumers
Detail layout & cards _resource-detail-shared.scss, overviewStatistics (@for), single-icon binding & createFiletreeFixture Dataset detail, model detail, versions browser, filetree
Settings tab ResourceDetailSettingsComponent (div[texeraResourceDetailSettings]), saveTextSetting Dataset detail Settings, model detail Settings
Creator & contributor forms resourceNameAndDescriptionFields, contributorInput, createFormlyModalFixture Dataset creator, model creator, contributor editor
Version uploader Table-driven loadUploadSettings, shared stageFile/mount/expectAbortRequest test helpers Version uploader & spec

Any related issues, documentation, discussions?

Closes #9520.

How was this PR tested?

Ran in frontend/ on 63e9447924:

  • yarn format:ci — passed
  • yarn tsc --noEmit -p src/tsconfig.app.json — passed
  • yarn tsc --noEmit -p src/tsconfig.spec.json — passed
  • yarn test:ci — 254 passed (254) files, 7290 passed | 1 skipped (7291) tests
  • yarn ng run gui:test-browser --watch=false --progress=false — 3 passed (3) files, 23 passed (23) tests in Chromium
  • yarn build:ci --skip-nx-cache — production build succeeded
  • Playwright Chromium (1280x980) against ng serve with stubbed /api/**: navigated to /user/dataset/1 (Data Card, Versions & Files, Settings) and /user/model/1 (Model Card, Settings) before and after refactoring to verify identical layout and controls.

Visual comparison (1280x980 desktop)

View Before (main) After (this PR)
Dataset Data Card Before dataset overview After dataset overview
Dataset Versions & Files Before dataset versions After dataset versions
Dataset Settings Before dataset settings After dataset settings
Model Card Before model overview After model overview
Model Settings Before model settings After model settings

Was this PR authored or co-authored using generative AI tooling?

Generated-by: Antigravity IDE (Gemini 3.8 Flash)

@aglinxinyuan aglinxinyuan added the refactor Refactor the code label Nov 17, 2026
Copilot AI balanced review requested due to automatic review settings November 17, 2026 09:03

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.

@aglinxinyuan aglinxinyuan added the frontend Changes related to the frontend GUI label Nov 17, 2026
@aglinxinyuan aglinxinyuan self-assigned this Nov 17, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Automated Reviewer Suggestions

Based on the git blame history of the changed files, we recommend the following reviewers:

  • Contributors with relevant context: @Ma77Ball, @tanishqgandhi1908, @xuang7
    You can notify them by mentioning @Ma77Ball, @tanishqgandhi1908, @xuang7 in a comment.

aglinxinyuan added a commit to aglinxinyuan/texera that referenced this pull request Nov 17, 2026
@codecov-commenter

codecov-commenter commented Nov 17, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 99.23077% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 91.62%. Comparing base (55e179a) to head (37abba0).

Files with missing lines Patch % Lines
...el/user-model-explorer/model-detail.component.html 88.88% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #9522      +/-   ##
============================================
+ Coverage     91.60%   91.62%   +0.02%     
+ Complexity     5053     4962      -91     
============================================
  Files          1285     1285              
  Lines         57136    56558     -578     
  Branches       7442     7368      -74     
============================================
- Hits          52337    51823     -514     
+ Misses         2915     2893      -22     
+ Partials       1884     1842      -42     
Flag Coverage Δ *Carryforward flag
access-control-service 77.44% <ø> (ø) Carriedforward from cc179d5
agent-service 99.56% <ø> (-0.01%) ⬇️ Carriedforward from cc179d5
amber 85.26% <ø> (-0.07%) ⬇️ Carriedforward from cc179d5
computing-unit-managing-service 63.94% <ø> (-0.09%) ⬇️ Carriedforward from cc179d5
config-service 87.37% <ø> (-0.13%) ⬇️ Carriedforward from cc179d5
file-service 81.87% <ø> (-0.29%) ⬇️ Carriedforward from cc179d5
frontend 96.42% <99.23%> (-0.01%) ⬇️
notebook-migration-service 83.77% <ø> (ø) Carriedforward from cc179d5
pyamber 98.50% <ø> (-0.01%) ⬇️ Carriedforward from cc179d5
workflow-compiling-service 78.30% <ø> (ø) Carriedforward from cc179d5

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

frontend Changes related to the frontend GUI refactor Refactor the code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Share dataset and model detail, creator, and uploader components

3 participants