Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,12 @@
<h1 align="center">Apache Texera - Human-AI Collaborative Data Science Using Visual Workflows</h1>

<p align="center">
<a href="https://texera.io"> <img src="frontend/src/assets/logos/full_logo_small.png" alt="texera-logo" height="150px"/> </a>
<a href="https://texera.apache.org/">
<picture>
<source media="(prefers-color-scheme: dark)" srcset="frontend/src/assets/logos/apache-texera-logo-white.svg">
<img src="frontend/src/assets/logos/apache-texera-logo.svg" alt="Apache Texera logo" height="120px"/>
</picture>
</a>
<br>
<i>Apache Texera (Incubating) is an open-source platform for human-AI collaborative data science using visual workflows.</i>
<br>
Expand Down
Binary file modified frontend/src/assets/logos/android-chrome-192x192.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified frontend/src/assets/logos/android-chrome-512x512.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
19 changes: 19 additions & 0 deletions frontend/src/assets/logos/apache-texera-icon.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
19 changes: 19 additions & 0 deletions frontend/src/assets/logos/apache-texera-logo-white.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
19 changes: 19 additions & 0 deletions frontend/src/assets/logos/apache-texera-logo.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified frontend/src/assets/logos/apple-touch-icon.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified frontend/src/assets/logos/favicon-16x16.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified frontend/src/assets/logos/favicon-32x32.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified frontend/src/assets/logos/favicon.ico
Binary file not shown.
Binary file modified frontend/src/assets/logos/full_logo_small.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified frontend/src/assets/logos/logo.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
4 changes: 2 additions & 2 deletions frontend/src/assets/logos/site.webmanifest
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "",
"short_name": "",
"name": "Apache Texera",
"short_name": "Texera",
"icons": [
{
"src": "assets/logos/android-chrome-192x192.png",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Must fix:

A relative icon path resolves against the manifest's own URL (MDN). This entry and line 11 therefore point at /assets/logos/assets/logos/android-chrome-*.png, which does not exist. The server answers that 404 with the index page (TexeraWebApplication.scala:118), so install and Add to Home screen never get the new icons. Use android-chrome-192x192.png and android-chrome-512x512.png (the paths date back to 11deb73).

Expand Down
8 changes: 4 additions & 4 deletions frontend/src/index.html
Original file line number Diff line number Diff line change
Expand Up @@ -33,21 +33,21 @@
content="no-referrer-when-downgrade" />

<link
href="assets/logos/apple-touch-icon.png?v=1"
href="assets/logos/apple-touch-icon.png?v=2"
rel="apple-touch-icon"
sizes="180x180" />
<link
href="assets/logos/favicon-32x32.png?v=1"
href="assets/logos/favicon-32x32.png?v=2"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Advisory:

Should this ?v=2 survive page load? On every DashboardComponent route, loadLogos() sets every link[rel*='icon'] href to the favicon setting. That setting defaults to the unversioned assets/logos/favicon-32x32.png (default.conf:36). So the version is dropped, and apple-touch-icon lands on the 32px favicon. I could not confirm whether browsers then reuse the old cached icon. If the bump matters, select only link[rel='icon'] and skip the rewrite when the setting names a shipped icon, or file a follow-up.

rel="icon"
sizes="32x32"
type="image/png" />
<link
href="assets/logos/favicon-16x16.png?v=1"
href="assets/logos/favicon-16x16.png?v=2"
rel="icon"
sizes="16x16"
type="image/png" />
<link
href="assets/logos/site.webmanifest?v=1"
href="assets/logos/site.webmanifest?v=2"
rel="manifest" />

<!-- Add Angular Material Fonts -->
Expand Down
Loading