Repository navigation
chore(frontend): adopt the Apache Texera logo #9539
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -33,21 +33,21 @@ | |
| content="no-referrer-when-downgrade" /> | ||
|
|
||
| <link | ||
| href="assets/logos/apple-touch-icon.png?v=1" | ||
| href="assets/logos/apple-touch-icon.png?v=2" | ||
| rel="apple-touch-icon" | ||
| sizes="180x180" /> | ||
| <link | ||
| href="assets/logos/favicon-32x32.png?v=1" | ||
| href="assets/logos/favicon-32x32.png?v=2" | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Advisory: Should this |
||
| rel="icon" | ||
| sizes="32x32" | ||
| type="image/png" /> | ||
| <link | ||
| href="assets/logos/favicon-16x16.png?v=1" | ||
| href="assets/logos/favicon-16x16.png?v=2" | ||
| rel="icon" | ||
| sizes="16x16" | ||
| type="image/png" /> | ||
| <link | ||
| href="assets/logos/site.webmanifest?v=1" | ||
| href="assets/logos/site.webmanifest?v=2" | ||
| rel="manifest" /> | ||
|
|
||
| <!-- Add Angular Material Fonts --> | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Must fix:
A relative icon path resolves against the manifest's own URL (MDN). This entry and line 11 therefore point at
/assets/logos/assets/logos/android-chrome-*.png, which does not exist. The server answers that 404 with the index page (TexeraWebApplication.scala:118), so install and Add to Home screen never get the new icons. Useandroid-chrome-192x192.pngandandroid-chrome-512x512.png(the paths date back to 11deb73).