Repository navigation
TIKA-5001: step 1 - #3436
Merged
Merged
TIKA-5001: step 1#3436
Conversation
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
Cross-process persistence and legacy-store precedence need integration-test confirmation and human review before approval.
No open issues 🎉
What changed in this PR
This first step of TIKA-5001 separates server-configured components from runtime registrations in Tika’s pipes infrastructure, keeping resolved config-file secrets out of persistent stores.
Changes:
- Preserve config-file components separately, give them precedence over stored copies, and prevent runtime replacement or deletion.
- Update manager and gRPC tests to cover runtime changes, persistence separation, and forked-worker access.
- Document the revised persistence and mutation rules.
| File | Description |
|---|---|
| tika-pipes/tika-pipes-integration-tests/src/test/java/org/apache/tika/pipes/core/fetcher/FetcherManagerTest.java | Tests configured-fetcher protection, persistence separation, and legacy-store precedence. |
| tika-pipes/tika-pipes-integration-tests/src/test/java/org/apache/tika/pipes/core/emitter/EmitterManagerTest.java | Tests runtime updates and configured-emitter protection. |
| tika-pipes/tika-pipes-core/src/main/java/org/apache/tika/pipes/core/fetcher/FetcherManager.java | Documents the configured-fetcher replacement restriction. |
| tika-pipes/tika-pipes-core/src/main/java/org/apache/tika/pipes/core/emitter/EmitterManager.java | Documents the configured-emitter replacement restriction. |
| tika-pipes/tika-pipes-core/src/main/java/org/apache/tika/pipes/core/AbstractComponentManager.java | Separates configured components from runtime storage and updates lookup, listing, and mutation handling. |
| tika-grpc/src/test/java/org/apache/tika/pipes/grpc/TikaGrpcServerTest.java | Adjusts runtime-registration tests and adds file-store coverage for forked workers. |
| docs/modules/ROOT/pages/using-tika/grpc/index.adoc | Explains restrictions on modifying configured fetchers. |
| docs/modules/ROOT/pages/pipes/configuration.adoc | Clarifies runtime-only storage and the file backend. |
| docs/modules/ROOT/pages/configuration/index.adoc | Explains that resolved config-file references are not persisted. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for your contribution to Apache Tika! Your help is appreciated!
Before opening the pull request, please verify that
TIKA-XXXX)[TIKA-XXXX] Issue or pull request title)./mvnw clean install(clean testalone cannot resolve the pipes plugin zips)Generated-by: <tool>in the commit message), and consider running the pre-flight in.skills/devs/pr-review/SKILL.md— fix what it finds; don't paste its report heremainbranch. If there are conflicts, please try to rebase the pull request branch on top of a freshly pulledmainbranchtika-bom/pom.xml.We will be able to faster integrate your pull request if these conditions are met. If you have any questions how to fix your problem or about using Tika in general, please sign up for the Tika mailing list. Thanks!