Use outer join to get data from both tables - #96
Merged
tofu-rocketry merged 4 commits intoSep 10, 2026
Merged
Conversation
tofu-rocketry
requested changes
Sep 9, 2026
tofu-rocketry
left a comment
tofu-rocketry
left a comment
Member
There was a problem hiding this comment.
The code looks good, but it's the commit messages again. See notes below. Ensure that they're formatted correctly, i.e. short header line then longer body where necessary.
Use outer join to get data from both tables
- This isn't a good explanation of an outer join - we're already getting data from both tables - so you really mean we're keeping rows even if they don't fully match between the tables
- Also need a "why" we're doing this. Something about showing a wider variety of accounting data issues.
Allow null to show the records which is not available in both tables
- Explain why these records might not be available.
Check for nan to allow display of records not present in both tables
- "NaN" rather than nan. 👵🏻
- Need to add something about this being to ensure that NaNs aren't passed onwards.
- Also explain addition of the helper function.
Check RecordCountInDb to note the omission
- What does this mean? Do you mean handle it separately so that we can reduce the WARNING to an OK?
Fix indentation
- Fine.
Use an outer join when combining summary and sync record data so that rows are retained even when they only exist in one source. This exposes a wider range of accounting and publication issues, including records that are missing from either VSuperSummaries or VSyncRecords.
Some records can exist in VSyncRecords without a corresponding published summary record. Allow RecordStart and RecordEnd to be null so these records can be displayed.
Convert Pandas NaN and NaT values to None for dates and zero for counts before storing records and add a helper function to centralise the conversion logic. This prevents invalid values being passed to Django model fields and ensures unmatched records are displayed correctly.
Avoid flagging records as invalid solely because sync record is unavailable. Fix indentation
garaimanoj
force-pushed
the
gt-1750-sites-missing-from-sync-views
branch
from
September 10, 2026 09:01
2f0844a to
9cc8e63
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves GT-1750
Resolves #36