Repository navigation
fix(ios): define RCT_NEW_ARCH_ENABLED in Package.swift - #805
Merged
janicduplessis merged 1 commit intoNov 3, 2026
Merged
Conversation
|
@chrfalch is attempting to deploy a commit to the appandflow Team on Vercel. A member of the Team first needs to authorize it. |
janicduplessis
approved these changes
Nov 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SwiftPM builds do not get the new-architecture TurboModule code.
Package.swiftdefines onlyDEBUGandNDEBUG.ios/RNCSafeAreaContext.mmputs-getTurboModule:inside#ifdef RCT_NEW_ARCH_ENABLED, so SwiftPM builds leave it out.This PR adds
.define("RCT_NEW_ARCH_ENABLED", to: "1")tocSettingsandcxxSettings. The define has no condition, because the SwiftPM target already compiles the Fabric sources with no condition. The guarded blocks have no#elsebranch, so no old-architecture code is lost.To check: run
yarn jest src/__tests__/swiftpm-test.ts. All 5 tests should pass. The contract test now expects both defines.Checked with https://github.com/schiewe/react-native-swiftpm-new-arch-repro, in a Release build for the iOS simulator:
nmfinds no-[RNCSafeAreaContext getTurboModule:]in the app binary.nmfinds-[RNCSafeAreaContext getTurboModule:], and the build log shows-DRCT_NEW_ARCH_ENABLED=1.Follow-up to react-native-community/discussions-and-proposals#994 (comment).