Skip to content

fix(ios): skip provider inset reports while outside a window #807

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
floco-af wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

fix(ios): skip provider inset reports while outside a window #807

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions ios/Fabric/RNCSafeAreaProviderComponentView.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,18 @@ - (void)willMoveToSuperview:(UIView *)newSuperView
[self registerNotifications];
}
}

- (void)didMoveToWindow
{
[super didMoveToWindow];

// Insets measured while outside a window are skipped, so measure again on entry. safeAreaInsetsDidChange only
// fires when the value changes, which it may not if the in-window insets equal the zero held outside the window.
// Ask for a layout pass instead of reading here: UIKit may not have updated safeAreaInsets yet.
if (self.window != nil) {
[self setNeedsLayout];
}
}
#endif

- (void)registerNotifications
Expand Down Expand Up @@ -88,6 +100,13 @@ - (void)invalidateSafeAreaInsetsMeasuringCorners:(BOOL)measureCorners
if (self.superview == nil) {
return;
}
#if !TARGET_OS_OSX
// A view outside a window reports zero safeAreaInsets, e.g. a tab of a native tab container that has not been
// selected yet. Keyboard notifications would send that zero to JS, so wait until the view enters a window.
if (self.window == nil) {
return;
}
#endif
// This gets called before the view size is set by react-native so
// make sure to wait so we don't set wrong insets to JS.
if (CGSizeEqualToSize(self.frame.size, CGSizeZero)) {
Expand Down
Loading