Repository navigation
Conversation
|
|
Cover the default and custom-level configurations of setup_logger. An autouse fixture restores the shared module logger after each test, since setup_logger adds a handler on every call.
Dor-bl
force-pushed
the
mirror/test-setup-logger
branch
from
November 8, 2026 21:48
c6b7a90 to
a9980e2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
test/unit/common/logger_test.pycoveringsetup_logger()with the default level and withlogging.DEBUG:propagateis off, the level is set, and exactly oneStreamHandlertosys.stderris added.setup_loggermutates the shared module logger (it adds a handler on every call), so an autouse fixture snapshots and restores the logger's handlers, level andpropagateafter each test, so the rest of the suite isn't affected.make unittest: all passruff check,ruff format --check: clean