Skip to content

fix: copy advanced commerce item lists #300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
visheshupadhyay wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: copy advanced commerce item lists #300

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/main/java/com/apple/itunes/storekit/model/HelperValidationUtils.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

package com.apple.itunes.storekit.model;

import java.util.ArrayList;
import java.util.List;
import java.util.Objects;

Expand Down Expand Up @@ -87,7 +88,7 @@ public static <T> List<T> validateItems(List<T> list) {
}
}

return list;
return new ArrayList<>(list);
}

private static String validateStringWithMaxLength(String value, int maxLength, String fieldName) {
Expand All @@ -97,4 +98,4 @@ private static String validateStringWithMaxLength(String value, int maxLength, S
}
return value;
}
}
}
3 changes: 2 additions & 1 deletion src/test/java/com/apple/itunes/storekit/model/AdvancedCommerceModelsTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1163,8 +1163,9 @@ public void testAdvancedCommerceSubscriptionReactivateInAppRequestItemsValidatio

@Test
public void testAdvancedCommerceRequestAddItemAppendsToList() {
AdvancedCommerceSubscriptionPriceChangeRequest priceChangeRequest = new AdvancedCommerceSubscriptionPriceChangeRequest(createRequestInfo(), new ArrayList<>(List.of(new AdvancedCommerceSubscriptionPriceChangeItem("sku", 1000L))))
AdvancedCommerceSubscriptionPriceChangeRequest priceChangeRequest = new AdvancedCommerceSubscriptionPriceChangeRequest(createRequestInfo(), List.of(new AdvancedCommerceSubscriptionPriceChangeItem("sku", 1000L)))
.addItem(new AdvancedCommerceSubscriptionPriceChangeItem("sku2", 2000L));

Assertions.assertEquals(List.of(new AdvancedCommerceSubscriptionPriceChangeItem("sku", 1000L), new AdvancedCommerceSubscriptionPriceChangeItem("sku2", 2000L)), priceChangeRequest.getItems());

AdvancedCommerceSubscriptionCreateRequest createRequest = new AdvancedCommerceSubscriptionCreateRequest(createRequestInfo(), "USD", new AdvancedCommerceDescriptors("description", "display name"), new ArrayList<>(List.of(new AdvancedCommerceSubscriptionCreateItem("sku", "description", "display name", 1000L))),
Expand Down