Repository navigation
Conversation
Collaborator
|
Resolved via #218 |
Author
|
you used my fix on your commit? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deserializing
AdvancedCommerceSubscriptionModifyDescriptorswitheffective: "IMMEDIATELY"or"NEXT_BILL_CYCLE"leaveseffectiveasNone, even thoughrawEffectivecontains a recognized value. The same happens when constructing the model withrawEffective, and an enum-valued model no longer compares equal after a serialization round trip.Inherit
AttrsRawValueAware, as the sibling period-change model does, so initialization synchronizes the enum and raw fields. Add coverage for both known values, round trips, unknown values, and later assignments.Validation on Windows / Python 3.12: the fixture assertion and four regression subtests fail before the fix. Afterward, the full suite passes: 225 tests and 4 subtests (
python -m pytest tests -q).git diff --checkpasses.