Repository navigation
build(env): stop installing lychee during env setup - #159
Open
dengqiaoyu wants to merge 1 commit into
Open
dengqiaoyu wants to merge 1 commit into
dengqiaoyu wants to merge 1 commit into
Conversation
- The OSS pre-commit config has no lychee hook, but `install_pre_commit_hooks.sh` installed lychee on every fresh venv, including CI runs with INSTALL_PRECOMMIT=false - On GitHub-hosted Linux runners `apt-get` has no sudo, so the install fell back to `cargo install lychee`, which took ~195s of the nightly wheel build's 3m41s `make` step
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
install_pre_commit_hooks.shinstalled lychee on every fresh venv, including CI runs with INSTALL_PRECOMMIT=falseapt-gethas no sudo, so the install fell back tocargo install lychee, which took ~195s of the nightly wheel build's 3m41smakestep