Skip to content

fix: mirrored orientation in GetPhaseTransform #109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Rubeanie wants to merge 1 commit into
base: main
Choose a base branch
from
+5 −7
Open

fix: mirrored orientation in GetPhaseTransform #109

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 5 additions & 7 deletions plug-ins/Apple.PHASE/Apple.PHASE_Unity/Assets/Runtime/PHASEHelpers.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -812,13 +812,11 @@ static public MeshData GetMeshData(MeshFilter meshFilter, Transform transform)
/// <returns> A <c>Matrix4x4</c> representing a transform in PHASE coordinates. </returns>
static public Matrix4x4 GetPhaseTransform(Transform inTransform)
{
Matrix4x4 phaseTransform = new Matrix4x4(inTransform.right, inTransform.up, inTransform.forward, new Vector4());
Vector3 position = RhConversionMat * inTransform.position;
phaseTransform.m30 = position.x;
phaseTransform.m31 = position.y;
phaseTransform.m32 = position.z;
phaseTransform.m33 = 1.0f;
return phaseTransform;
// RhConversionMat (S) flips Z. S * M * S keeps a proper rotation; flipping one
// side only gave a reflection. The native side reads this matrix transposed,
// so pass S * M^T * S.
Matrix4x4 rigid = Matrix4x4.TRS(inTransform.position, inTransform.rotation, Vector3.one);
return RhConversionMat * rigid.transpose * RhConversionMat;
}

static private Vector3 GetCombinedHierachyScale(Transform inTransform)
Expand Down