Repository navigation
Add remove-ace.sh for Flux and fargocd (Argo CD) setups - #1387
Open
ArnobKumarSaha wants to merge 3 commits into
Open
ArnobKumarSaha wants to merge 3 commits into
ArnobKumarSaha wants to merge 3 commits into
Conversation
delete-helmrelease.sh deletes HelmReleases one by one and unblocks stuck ones per mode: for fargocd-mirrored HRs it clears finalizers of the Application's terminating objects (Argo CD never clears argocd.argoproj.io/hook-finalizer of Helm hooks on Application delete); for Flux HRs it clears those of the release manifest. remove-ace.sh is the runner: it requires the Flux controllers only for Flux-managed HRs (fargocd/Argo CD otherwise), removes aceshifter after the core releases that depend on it, and warns about KubeDB/KubeStash objects outside ACE namespaces. Signed-off-by: Arnob kumar saha <arnob@appscode.com>
… in remove-ace.sh Signed-off-by: Arnob kumar saha <arnob@appscode.com>
Signed-off-by: Arnob kumar saha <arnob@appscode.com>
ArnobKumarSaha
force-pushed
the
arnob-uninstall
branch
from
October 30, 2026 11:54
061d397 to
3261f99
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
uninstall-ace.shexits on Argo CD setups (e.g. OpenShift), where HelmReleases are only mirrored into Argo CD Applications by fargocd and Flux controllers are absent. This adds two scripts next to it (it is left unchanged):hack/deploy/delete-helmrelease.sh <ns> [hr...] [--timeout=2m] [--force]: deletes HRs one by one. On timeout:argocd.argoproj.io/hook-finalizerof Helm-hook objects (e.g. kube-ui-server's ClusterRoles) when an Application is deleted.--force: last resort, clears the Application or HR finalizer.hack/deploy/remove-ace.sh [--full-prune] [--force]: runner, same flow asuninstall-ace.sh, plus:fargocd+argocd-application-controllerfor fargocd-managed ones;aceshifterjoins the core set, removed in its own dependsOn order after the other core releases (it used to land in wave 1, because the core HRs depending on it are excluded from the graph);Tested: the manual equivalent of this order on an ARO (OpenShift 4.21) + Argo CD cluster. The scripts only passed
bash -n; they haven't been run end to end.