Repository navigation
Always render EnvoyProxy in service-gateway - #1388
Merged
Merged
Conversation
The EnvoyProxy CRD is installed by the voyager-gateway crd-manager pre-install hook. Under Argo CD the chart is rendered before that hook runs, so the Capabilities check dropped the EnvoyProxy object on first install and the GatewayClass pointed at a missing parametersRef. Signed-off-by: Arnob kumar saha <arnob@appscode.com>
ArnobKumarSaha
added a commit
that referenced
this pull request
Oct 30, 2026
Signed-off-by: Arnob kumar saha <arnob@appscode.com> (cherry picked from commit cd618ac) Signed-off-by: Arnob kumar saha <arnob@appscode.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The EnvoyProxy CRD is installed by the voyager-gateway crd-manager pre-install hook. Argo CD renders the chart before that hook runs, so
.Capabilities.APIVersions.Has "gateway.envoyproxy.io/v1alpha1/EnvoyProxy"was false on first install. The EnvoyProxy object was dropped, and the GatewayClassparametersRefpointed to a missing object. Automated sync without selfHeal never re-applied it.templates/gateway/gwclass.yaml.argocd.argoproj.io/sync-options: SkipDryRunOnMissingResource=trueso Argo CD's dry-run doesn't fail before the CRD exists.