Repository navigation
Stop emailing on blocked license requests - #134
Merged
Merged
Conversation
Requests from blocked domains, emails, or clusters no longer send the [LICENSE_BLOCKED] notification email; the attempt is still recorded as a license_blocked event and the request is still rejected. Removes the now-unused NewBlockedLicenseMailer. Signed-off-by: Tamal Saha <tamal@appscode.com>
![kodiak-appscode[bot]](https://avatars.githubusercontent.com/in/92481?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
[LICENSE_BLOCKED]notification emailrecordLicenseEvent(..., EventTypeLicenseBlocked)and the request is still rejected with the "contact support" errorNewBlockedLicenseMailer/mail_blocked_license.goTest plan
go build -mod=vendor ./...go test -mod=vendor -race ./pkg/server/.../issue-licensewith a blocked domain/email/cluster and confirm no email is sent, the request is rejected, and alicense_blockedevent is still recorded