Conversation
The diagnose report prints every configuration option with the value it holds, and nothing else. An option that is not what the application set is the first thing somebody looks at, and the report gives them no way to tell a default apart from a value read from the environment, so the next step is guesswork. The Ruby gem's report has named the source for years. Print the source beside the value, and, for an option more than one source holds, list each source with what it holds in the order they are merged. The order comes from the same constant the merge walks, so the report cannot disagree with the merge about which value wins.
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The diagnose report prints every configuration option with the value it
holds, and nothing else. An option that is not what the application set
is the first thing somebody looks at, and the report gives them no way
to tell a default apart from a value read from the environment, so the
next step is guesswork. The Ruby gem's report has named the source for
years.
Print the source beside the value, and, for an option more than one
source holds, list each source with what it holds in the order they are
merged. The order comes from the same constant the merge walks, so the
report cannot disagree with the merge about which value wins.
The diagnose test expectations move with it, in diagnose_tests#159.
Kept apart from #287 so the two can be judged on their own. When both land,
derivedjoinsSOURCE_ORDERand the expectations gain a line for it.