Do not build with hatchling 1.32.1 - #289
Merged
Merged
Conversation
The package names `hatchling` as its build backend without a version, so a build takes whichever release is newest. In 1.32.1 `hatchling.builders.binary` imports `hatch.plugin.manager` at module level, and it needs it at runtime rather than for typing alone, because the names it reads from it are the type arguments of two class definitions. A build environment holds the backend and not the tool, so registering the builder plugins raises `ModuleNotFoundError: No module named 'hatch'` and no wheel is built. Exclude that one release, so a build takes 1.32.0 or whichever later release drops the import again.
|
Hi @unflxw, We've found some issues with your Pull Request.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The package names
hatchlingas its build backend without a version, so a build takes whichever release is newest. In 1.32.1hatchling.builders.binaryimportshatch.plugin.managerat module level, and it needs it at runtime rather than for typing alone, because the names it reads from it are the type arguments of two class definitions. A build environment holds the backend and not the tool, so registering the builder plugins raisesModuleNotFoundError: No module named 'hatch'and no wheel is built. Exclude that one release, so a build takes 1.32.0 or whichever later release drops the import again.hatchling 1.32.1 was published today, which is why the
Build packagejob started failing on every branch this afternoon. The same job passed this morning on the same code.[skip changeset]