basic implementation of fungible asset client - #7
Open
fishronsage wants to merge 1 commit into
Open
Conversation
Contributor
Author
|
Hi, @davidiw, can you review this PR? |
Contributor
|
cc @gregnazario |
Contributor
|
how did I miss this?? |
davidiw
reviewed
Jun 4, 2024
davidiw
left a comment
davidiw
left a comment
Contributor
There was a problem hiding this comment.
I think this might suffice for a trivial FAC, but I kinda wanted to do the following:
- Make a generic object client from this https://github.com/aptos-labs/aptos-python-sdk/blob/main/aptos_sdk/aptos_token_client.py#L301
- Make it so that we have some framework to register the parsers or figure out some solution there
- Make FAC actually capable of reading the object
what do you think?
fishronsage
force-pushed
the
fa
branch
2 times, most recently
from
June 18, 2024 08:20
57e5bd4 to
2a1a5c8
Compare
gregnazario
added a commit
that referenced
this pull request
May 28, 2026
…rror - type_tag.py: TypeTag.__eq__ now compares primitives by variant only — two TypeTags with the same primitive variant (e.g. BoolTag(True) vs BoolTag(False)) represent the same Move type and compare equal. VectorTag/StructTag still compare full value equality. Removes inconsistency introduced by the BCS fix (PR review #6) where deserialized primitives always receive placeholder values. - type_tag.py: Remove @lru_cache from StructTag.from_str. StructTag is mutable (contains type_args: list[TypeTag]) so caching and returning the same instance allowed callers to corrupt the cache via mutation. Drop the unused lru_cache import. - mnemonic.py: Wrap int(parts[N]) calls in try/except ValueError and re-raise as InvalidMnemonicError with a "Non-numeric segment" message. Previously a path like m/44'/637'/x'/0'/0' raised ValueError instead of the function's documented error type. Applied to both derive_ed25519_private_key and derive_secp256k1_private_key. - transfer_coin.py: Set last_error = None when the indexer returns a successful non-empty response before break. A transient early IndexerError no longer causes the soft-skip branch to fire when a later iteration succeeds.
gregnazario
added a commit
that referenced
this pull request
Jun 12, 2026
…rror - type_tag.py: TypeTag.__eq__ now compares primitives by variant only — two TypeTags with the same primitive variant (e.g. BoolTag(True) vs BoolTag(False)) represent the same Move type and compare equal. VectorTag/StructTag still compare full value equality. Removes inconsistency introduced by the BCS fix (PR review #6) where deserialized primitives always receive placeholder values. - type_tag.py: Remove @lru_cache from StructTag.from_str. StructTag is mutable (contains type_args: list[TypeTag]) so caching and returning the same instance allowed callers to corrupt the cache via mutation. Drop the unused lru_cache import. - mnemonic.py: Wrap int(parts[N]) calls in try/except ValueError and re-raise as InvalidMnemonicError with a "Non-numeric segment" message. Previously a path like m/44'/637'/x'/0'/0' raised ValueError instead of the function's documented error type. Applied to both derive_ed25519_private_key and derive_secp256k1_private_key. - transfer_coin.py: Set last_error = None when the indexer returns a successful non-empty response before break. A transient early IndexerError no longer causes the soft-skip branch to fire when a later iteration succeeds.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR implements a basic Fungible Asset Client for Aptos FA