Repository navigation
Fix ignored grid drags, overlapping placement, and response time - #58
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ordinary Focus grid drags could do nothing when reflow had no space, or move and roll back when an overlapped app refused resizing. Place only the selected window by default, retain group reflow as an explicit option, and let Ctrl-drag place even while Ctrl remains held from the opening shortcut.
Single-window placement checks native minimums, accommodates a verified larger minimum within the same transaction, preserves Undo, and uses a shorter settling interval without weakening guarded group occupancy checks.
Validation: Release build passed with warnings as errors; main-based core checks passed 8,237 assertions. The implementation received independent review and local native coverage for overlap, delayed responses, dynamic minimums, maximized restore, and Undo. Normal native fixture placements completed in roughly 63–94 ms on a 7680 × 4236 work area at 175% scaling.
The full native suite has a separately reproduced baseline failure in Recursive Grid maximized sizing at this DPI; details are in docs/VALIDATION.md. Physical input across representative applications and mixed-monitor hardware remains manual validation.
This branch contains only the grid fix. It excludes the unrelated move-anywhere feature in PR #57 and release automation in PR #56. Merge into main explicitly authorized by the owner in the task conversation.