Repository navigation
test: load runtime config tests from a temp directory - #11
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the failing tests in the Publish to NPM run for
1.5.0(job). In that run, 13 Express tests got{ payload: ... }with snake_case keys where they expected{ data: ... }.Cause
Two tests in
tests/config.spec.tswroteresora.config.cjs(withrootKey: 'payload'andpreferredCase: 'snake') into the repository root. Vitest runs test files in parallel, so whentests/express.spec.tsloaded the runtime config at the wrong moment, it picked up that file. The failure depends on timing, which is why the same commit passed CI.Fix
Those two tests now write the config into a temporary directory and point
process.cwd()at it withvi.spyOn. Nothing is written to the repository root any more, and the backup/restore code is no longer needed.Testing
I ran
pnpm testfive times while watching forresora.config.cjsin the repository root. All 234 tests passed each time, and the file never appeared.pnpm lintpasses.After this merges, re-run the publish workflow manually with version
1.5.0.