Repository navigation
fix: forward async data errors to awaiting callers - #12
Merged
Merged
Conversation
Awaiting a resource only listens to the callbacks passed to then(), so a rejected serialization left the request hanging and surfaced as an unhandled rejection instead of reaching the framework's error handler.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When a resource's async
data()throws,await resourcenever settles.awaitonly listens to the callbacks passed tothen(), butrunThenrejected the promise it returned without callingonrejected. The request hung and the error escaped as an unhandled rejection, which crashes the process on Node 15+ instead of reaching Express/H3 error handlers.This affected
Resource,ResourceCollectionandGenericResourcewhen awaited directly (or returned from an H3 handler).await resource.response()already worked.Fix
BaseSerializer.runThennow runs serialization indispatchThenand chainsonfulfilled/onrejectedon its result, so errors fromdata(),withResponseor plugins reach the caller.Tests
tests/async-errors.spec.tscovers awaiting each serializer,catch(), the Express error middleware (direct await andresponse()), and the H3onErrorhandler. Five of these fail (hang) without the fix. Full suite: 241 passing, lint and typecheck clean.