-
Notifications
You must be signed in to change notification settings - Fork 13
feat(desktop): stacked PRs link to chats and land as Work cards #1242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
arul28
wants to merge
11
commits into
main
Choose a base branch
from
cursor/stacked-pr-chat-peek-9b28
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+5,030
−330
Open
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
dc99000
feat(desktop): stacked PRs link to chats and land as Work cards
cursoragent 8840611
test(prs): pin stack-land emit count and compact TUI PR chip
cursoragent 6531d8a
merge(main): Linux Cloud Agent desktop bootstrap
cursoragent fcae814
fix(prs): quality pass for stacked chat peek and stack merge
cursoragent 623236c
fix(prs): stacked rebase fallback and shorter merge poll
cursoragent 8a3535f
fix(prs): stacked merge timeout, link refusals, and CI pins
cursoragent c93620a
fix(prs): do not tombstone rolled-back stack links
cursoragent 6a7289f
fix(prs): close remaining stack review threads
cursoragent 3545328
fix(prs): wait for every stack layer before reporting merge success
cursoragent 08d7673
fix(prs): verify 202 stack merges from GitHub, not an empty cache
cursoragent f2522c7
fix(prs): close remaining valid stacked-PR review findings
cursoragent File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔒 Security & Privacy | 🛡️ Analyzed with Security Review | 🟠 Major | ⚡ Quick win
🧩 Analysis chain
🏁 Script executed:
Repository: arul28/ADE
Length of output: 14285
🏁 Script executed:
Repository: arul28/ADE
Length of output: 42539
IDOR
Reachability: External
Exploitability: Moderate
CWE: CWE-639 — Authorization Bypass Through User-Controlled Key (IDOR)
Authorize the explicit
sessionIdbefore linking the PR.The externally exposed tool accepts
sessionId, and the handler uses it instead ofsession.identity.chatSessionId.createFromLaneforwards it tolinkPrToChatSessionwithallowCrossLane: true. The helper validates that the session exists, but does not verify caller ownership before writing the link. A caller who knows another valid session ID can associate the new PR with that session.Reject unauthorized explicit IDs, or bind the link to
session.identity.chatSessionId. Add a test that rejects a different valid session ID without creating the link.🤖 Prompt for AI Agents
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Skipped as invalid vs product:
create_pr_from_laneis an in-project agent tool. PassingsessionIdis the same explicit chat pick as the desktop/TUI picker (allowCrossLane: trueafter the session is verified to exist). Binding only tosession.identity.chatSessionIdwould break opening a PR for a chosen sibling chat in the same project. Fixed inf2522c7b4instead: emptylinkChatStackoffers now return{ ok: false }, unsupported remotemergeMethodis rejected, and TUIpr-openuses the form's captured session id.