Skip to content

Unify Desktop controls and refresh the README preview - #21

Merged
askac merged 3 commits into
mainfrom
feature/desktop-toolbar-readme
Sep 10, 2026
Merged

Unify Desktop controls and refresh the README preview#21
askac merged 3 commits into
mainfrom
feature/desktop-toolbar-readme

Conversation

@askac

@askac askac commented Sep 10, 2026

Copy link
Copy Markdown
Owner

Why

Terminal actions are split between the Core status bar and Desktop menus. Capture feedback resembles a menu option, repeated save dialogs interrupt capture, and the README preview does not show the current Desktop experience.

What changed

  • Place shared terminal controls beside tabs while retaining terminal-target checks and close-all confirmation.
  • Add isolated Desktop menus, original SVG capture controls, remembered folders, pause-aware recording time, and fading notices; preserve Core sandboxing, silent WebM and no-overwrite saves, with folder selection when a saved destination is unavailable.
  • Offer explicitly requested browser-access actions with existing authorization checks, add bounded capture diagnostics, and clean up smoke-test timers and unintended dialogs.
  • Replace the README hero animation with the user-selected real Desktop screenshot; retain the old animation asset.

Testing

  • All 78 Desktop unit tests pass, covering notification lifetimes, capture state, isolation, permissions and authorization boundaries.
  • Core browser and headless checks cover terminal targeting and existing workflows.
  • Windows-with-WSL source and packaged capture checks pass; the user confirms successful installation and notification behavior.
  • Native Windows packaged capture still intermittently reports UnknownVizError. Native macOS requires physical acceptance testing; these limitations are documented.

No version bump, installer upload or release publication is included.

## Why
Terminal actions are spread across the status bar and native menus. Capture feedback resembles a menu item, and repeated save dialogs interrupt screenshot and recording workflows.

## What changed
- Place shared terminal actions beside tabs and retain explicit target checks and close-all confirmation.
- Add isolated Desktop menus and original SVG capture controls while keeping Core and floating windows unprivileged; disable native actions when Core is unavailable.
- Remember capture folders, show pause-aware recording time, and fade transient notices; retain silent WebM, no-overwrite saves, and cancellation without starting capture.
- Add on-demand browser access actions with existing authorization checks, bounded capture diagnostics, and cleaned-up smoke-test timers.

## Testing
Desktop unit coverage passes all 78 tests. Core browser and headless checks cover tab targeting and existing workflows. Windows-with-WSL source and packaged capture checks pass, and the user confirms installation and UI behavior. Native Windows packaged capture remains intermittent with UnknownVizError; macOS still requires physical acceptance testing.
@askac
askac merged commit 6450f8c into main Sep 10, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant