Skip to content

agent-dispatch: test, then push; a local-only commit is not done - #54

Merged
asubbarao merged 2 commits into
mainfrom
rules/test-then-push
Oct 19, 2026
Merged

asubbarao merged 2 commits into
mainfrom
rules/test-then-push

Conversation

@asubbarao

Copy link
Copy Markdown
Owner

Replaces the house rule "nothing pushed, no PR, nothing another human can see, without his approval" with Test, then push: run the tests first, push only a green branch, open a ready PR with before/after test evidence. A commit that exists only locally is not done, and an untested push or PR is not allowed. Comments on other people's repos still need approval.

Docs-only change (skills/agent-dispatch/SKILL.md); no server file changes.

— Opus 5.5 (Claude Code), for Alok Subbarao

🤖 Generated with Claude Code

@asubbarao
asubbarao enabled auto-merge October 18, 2026 03:10
@asubbarao

Copy link
Copy Markdown
Owner Author

duckstack/review: failure

  • skills/agent-dispatch/SKILL.md:138 Section 4 of this file plus the CLAUDE.md house rule 'Evidence a teammate may see comes from CI/GitHub, never from local logfiles'; RULES.md 26-27: The new rule asks for before/after test evidence in the PR body but does not say where it comes from. Read as a pasted local run, it contradicts section 4 of the same file: local runs are for iteration only, a PR body is something a teammate sees, and section 4 requires false-first evidence (mutant, failing output, restored passing output) read from CI.
    Rewrite: - Test, then push. Run the tests locally first and push only a branch whose tests passed. Then open a ready (never draft) PR into the owner's repo. For before/after evidence in the body, link the CI runs and checks (gh run view --json read through shellfs) and give the false-first triple from section 4: the mutant, its failing CI output and the restored passing output. Never paste a local pytest | tail. The PR reaches main only through the review queue. A commit that exists only on this laptop is not done, and an untested push or PR is not allowed. Comments on other people's repos still need his yes.

Opus 5.5, duckstack review queue (duckstack-review skill)

asubbarao and others added 2 commits October 19, 2026 09:39
Replaces "nothing pushed without his approval": workers run the tests, push only a green branch, and open a ready
PR with the test evidence. Untested pushes are not allowed; comments on other people's repos still need approval.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@asubbarao
asubbarao force-pushed the rules/test-then-push branch from 6ebec0f to 46e4258 Compare October 19, 2026 16:40
@asubbarao

Copy link
Copy Markdown
Owner Author

duckstack/review: success

No findings.

Opus 5.5, duckstack review queue (duckstack-review skill)

@asubbarao
asubbarao merged commit 0d0b5d8 into main Oct 19, 2026
4 checks passed
@asubbarao
asubbarao deleted the rules/test-then-push branch October 19, 2026 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant