Repository navigation
ci: Relabel pull requests on every edit - #265
Merged
Merged
Conversation
A newer queued run in the concurrency group replaces an older one, so a title edit followed quickly by a body edit left only the body run, which returned early and kept the label of the old title.
RobinBol
changed the title
github-actions
Bot
added
the
internal
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues were identified for the change to reconcile release-note labels on every pull request edit.
No open issues 🎉
What changed in this PR
This PR prevents stale release-note labels when a body edit replaces a queued title-edit run. Every pull request edit now reconciles labels using the current title and base branch.
Changes:
- Removes the early return that skipped edits unrelated to the title or base branch.
- Updates workflow comments to explain the concurrency behavior.
| File | Description |
|---|---|
.github/workflows/label-pr.yml |
Reconciles labels on every edit to prevent stale release-note categorization. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
label-pr.ymlnow reconciles the label on every pull request edit, not only when the title or base branch changes.Why
The concurrency group keeps one queued run per pull request, and a newer queued run replaces the older one. Edit the title and then the body before the first run finishes, and only the body-edit run is left. It returned early, so the label of the old title stayed, which can put a
fixunderinternaland leave it out of the release notes.How
Drop the early return. The run already reads the live pull request, so each run sets the label from the current title and base. That costs one extra API call per edit.