Repository navigation
Add regression test for concurrent dub output reads - #335
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Protects the deadlock fix in #334 with an integration test that writes 1 MiB to stderr before completing stdout. A ten-second timeout makes sequential pipe reads fail instead of hanging CI. Runs in both the POSIX and Windows CI scripts.
Evidence
getDubInfo timed out while draining stdout and stderr.Concurrent dub output regression test passed, including on merged master.build/ci.shpasses. Windows execution is left to CI.Merge Danger
Door: two-way; test-only changes can be reverted.
Blast Radius: CI.