Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/Field/EmailField.php
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,9 @@ private function hasAnyDnsRecord(string $domain, array $types = ['MX', 'A', 'AAA

$records = @dns_get_record($domain . '.', $dnsConsts[$t]);
if ($records === false) { // retry once on failure
// @codeCoverageIgnoreStart
$records = dns_get_record($domain . '.', $dnsConsts[$t]);
// @codeCoverageIgnoreEnd
}
if ($records !== false && count($records) > 0) {
return true;
Expand Down
1 change: 1 addition & 0 deletions src/Persistence/Sql/Oracle/Connection.php
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ protected static function createDbalConfiguration(): Configuration

$configuration->setMiddlewares([
...$configuration->getMiddlewares(),
new RetryListenerConnectionMiddleware(),
new InitializeSessionMiddleware(),
]);

Expand Down
53 changes: 53 additions & 0 deletions src/Persistence/Sql/Oracle/RetryListenerConnectionMiddleware.php
Original file line number Diff line number Diff line change
@@ -0,0 +1,53 @@
<?php

declare(strict_types=1);

namespace Atk4\Data\Persistence\Sql\Oracle;

use Doctrine\DBAL\Driver;
use Doctrine\DBAL\Driver\Connection;
use Doctrine\DBAL\Driver\Exception as DbalDriverException;
use Doctrine\DBAL\Driver\Middleware;
use Doctrine\DBAL\Driver\Middleware\AbstractDriverMiddleware;

/**
* Oracle listener may temporarily return ORA-12516 when connecting and when the listener has not yet
* fully released previous connections.
*
* Needed for reliable connecting for Oracle v23.4 or higher (at least v23.26.3).
*/
class RetryListenerConnectionMiddleware implements Middleware
{
#[\Override]
public function wrap(Driver $driver): Driver
{
return new class($driver) extends AbstractDriverMiddleware {
private const RETRY_MAX_SECONDS = 10.0;
private const RETRY_INTERVAL_SECONDS = 0.02;

#[\Override]
public function connect(
#[\SensitiveParameter]
array $params
): Connection {
$sleepSecondsSum = 0;
while (true) {
try {
return parent::connect($params);
// @codeCoverageIgnoreStart
} catch (DbalDriverException $e) {
$sleepSeconds = self::RETRY_INTERVAL_SECONDS;
$sleepSecondsSum += $sleepSeconds;

if ($e->getCode() !== 12516 || $sleepSecondsSum > self::RETRY_MAX_SECONDS) {
throw $e;
}

usleep((int) round($sleepSeconds * 1_000_000));
// @codeCoverageIgnoreEnd
}
}
}
};
}
}
Loading