Repository navigation
fix: correct LinearSegmentedColormap typo and guard colormap re-registration - #436
Merged
Merged
Conversation
…tration Re-registering an already registered colormap name raises ValueError, which breaks module reloads (e.g. Spyder's module reloader). Also fix the mpl.colorsLinearSegmentedColormap typo in the dict branch, which was currently dead code but would raise AttributeError for dict-based colormaps.
olemke
force-pushed
the
fix-colormap-reregistration
branch
from
October 28, 2026 12:38
4c60308 to
0a01224
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re-registering an already registered colormap name raises ValueError, which breaks module reloads (e.g. Spyder's module reloader). Also fix the mpl.colorsLinearSegmentedColormap typo in the dict branch, which was currently dead code but would raise AttributeError for dict-based colormaps.