Repository navigation
test: handle FileNotFoundError from archive ls in TestFileSet - #437
Merged
Merged
Conversation
fsspec 2026.9.0 raises FileNotFoundError for paths missing from an archive instead of returning an empty listing. The zip tests on Windows relied on the empty listing to strip the drive prefix from the testfiles path, so catch the exception and keep the existing fallback. Zip entries never contain the drive letter, so the resulting path handling is otherwise unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With fsspec >= 2026.9.0, archive filesystems raise
FileNotFoundErrorwhen listing a path that is not present in the archive, instead of returning an empty listing. This broke the zip-parametrizedTestFileSettests, because_refdir_for_fslists the test files directory to decide whether to strip a leading separator or a Windows drive prefix. This PR makes the helper tolerant of both behaviors and cleans up the fallback logic so zip entries, which never contain a drive letter, resolve correctly.