Repository navigation
Conversation
|
Per |
c24e00b to
04e1d87
Compare
T8132 firmware exposes a report window and a small event-configuration window. Describe both resources and the optional per-device report entries. Assisted-by: LLM checkpatch Signed-off-by: Sean Dolbec <sdolbec1@gmail.com>
Describe the report and event-configuration resources published by T8132 firmware, along with the address cells used by optional report entries. Assisted-by: LLM checkpatch Signed-off-by: Sean Dolbec <sdolbec1@gmail.com>
A T8132 main DCP wired to fixed HDMI uses six firmware segments and shares the retained SID 0/SID 16 frontend contract with the external display path. Qualify that layout from the available main DCP and its connector role. Validate its physical framebuffer separately from inherited mappings and preserve both frontend streams without a board-name gate. Assisted-by: LLM checkpatch Signed-off-by: Sean Dolbec <sdolbec1@gmail.com>
Some T8132 desktops route the main DCP through a fixed DPTX-to-HDMI path instead of an internal panel. Use the existing connector-type property as that role contract, prepare the PHY and converter rails, adopt the retained firmware session, and register it through the external-output KMS path. Accept the retained physical framebuffer without manual bind controls or machine-name checks. Assisted-by: LLM checkpatch Signed-off-by: Sean Dolbec <sdolbec1@gmail.com>
The T8122 driver maps its core and DPTX windows by name. Describe those resource names now that the PHY has an implementation. Assisted-by: LLM checkpatch Signed-off-by: Sean Dolbec <sdolbec1@gmail.com>
T8122 uses a distinct cold activation sequence and a handful of link-rate register choices. Add the sequence, runtime-PM provider setup, and compatible so the fixed DPTX-to-HDMI path can use the generic PHY interface. Assisted-by: LLM checkpatch Signed-off-by: Sean Dolbec <sdolbec1@gmail.com>
The Mac mini routes its main DCP through the T8122 DPTX PHY and an HDMI converter controlled by two SMC GPIOs. Describe that fixed path and enable the retained DCP, mailbox, and display DART nodes. Do not attach the DCP or mailbox to DISP_CPU: iBoot leaves that domain in auto mode and direct PMGR writes fault on this machine. Assisted-by: LLM checkpatch Signed-off-by: Sean Dolbec <sdolbec1@gmail.com>
04e1d87 to
396679f
Compare
Codex Review Summary: ❌ FailedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
RyanTheTide
left a comment
RyanTheTide
left a comment
There was a problem hiding this comment.
Commit 7e92f49 is authored by Pavel Shago but carries only the submitter's Signed-off-by. It needs a Signed-off-by from its author as well (DCO, Documentation/process/submitting-patches.rst).
RyanTheTide
left a comment
RyanTheTide
left a comment
There was a problem hiding this comment.
Besides the Signed-off-by from its author still needed on 7e92f49:
-
This no longer merges into integration/aurora. drivers/phy/apple/dptx.c conflicts with c0e42a1 ("phy: apple: dptx: Add the T6050 variant", from #940, merged as 328654f). Please rebase and keep both the T6050 and T8122 variants.
-
The description lists the exact head as not booted. After the rebase, please add the J773g result for that head (HDMI connector and modes, desktop, cold and warm boot). iomfb_m4.c, dcp.c and apple-dart.c are shared with J713, so please also add a J713 internal and external display check.
Summary
This seven-patch series turns the J773g HDMI proof of concept into a bisectable chain: T8132 PMP report resources, main external-display DART handoff, retained main-DCP external output, the T8122 DPTX PHY, and the fixed J773g DPTX-to-HDMI DT path.
It does not duplicate the topology already merged through #1142 or the generalized M4 handoff on the base. Test-only admission, manual-bind controls, and unrelated changes are absent.
Provenance
The hardware behavior and register effects were observed during our own J773g witness runs and firmware-interface behavior. No Apple source code was copied. Pavel Shago identified retained-display and DPTX sequencing lessons; his authorship is retained on the T8122 PHY commit.
The notes-repo audit
aurora/upstream/mesa/PROVENANCE-NOV1-20261107.mdsupports the same boundary: no constants, encodings, or behavior in this work came from the November 1 G16G firmware disassembly.Results
Image modules dtbs; no new warnings in touched paths.--no-signoff.apple,tunableschema types abort decoding of unrelated existing Apple properties before J773g validation. This remains an un-draft gate.Hardware test plan
Before this leaves draft: boot the exact head on J773g, verify connector/mode state and a displayed desktop, exercise hotplug and suspend/resume, repeat cold and warm boots, and run the available J713 regression coverage. This PR stays draft until those affected-hardware checks and the DT validation gate are recorded.
The commits intentionally have no
Signed-off-byyet. The human submitter will add his own DCO sign-off after review, as required byDocumentation/process/coding-assistants.rst.