Repository navigation
drm/asahi: g17: read the QoS ID mask through its state lock in KUnit - #1211
Merged
Merged
Conversation
Commit 34b438d ("drm/asahi: g17: fence recycled firmware identities and storage") moved QosIds.used into the locked QosState, but failed_client_construction_returns_every_qos_id still read the old field, so every KUnit build with DRM_ASAHI failed with E0615 ("attempted to take value of method `used`"). Read the mask through the state lock. KUnit arm64 (drivers/soc/apple/sep.kunitconfig, all suites): 408 run, 406 pass, 2 skipped (config-gated), asahi_g17_qos_capacity 2/2. Fixes: 34b438d ("drm/asahi: g17: fence recycled firmware identities and storage") Signed-off-by: Ryan Murray <81541646+RyanTheTide@users.noreply.github.com> Assisted-by: LLM
RyanTheTide
added a commit
that referenced
this pull request
Nov 8, 2026
Brings #1211, the G17 QoS KUnit test fix. Signed-off-by: Ryan Murray <81541646+RyanTheTide@users.noreply.github.com> Assisted-by: LLM
RyanTheTide
added a commit
that referenced
this pull request
Nov 8, 2026
…Unit fix #1211) Signed-off-by: Ryan Murray <81541646+RyanTheTide@users.noreply.github.com> Assisted-by: LLM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#1176 (34b438d) moved
QosIds.usedinto the lockedQosState, but the KUnit testfailed_client_construction_returns_every_qos_idstill reads the old field. Since that merge, every KUnit build withDRM_ASAHIfails with E0615 (attempted to take value of method 'used'). The failure first showed in the kunit job of the aurora-wip sync #1210. This one-line test fix reads the mask through the state lock. It changes no driver code.Test: KUnit arm64 with
drivers/soc/apple/sep.kunitconfig, all suites, on the buildbox: 408 run, 406 passed, 2 skipped (config-gated).asahi_g17_qos_capacitypassed 2/2.🤖 Generated with Claude Code