Repository navigation
t8140: send the debug port's page select again until it takes - #1310
Closed
DjDeveloperr wants to merge 6 commits into
Closed
DjDeveloperr wants to merge 6 commits into
DjDeveloperr wants to merge 6 commits into
Conversation
…l it takes The cut selects a register page of the debug port's controller with one write, then reads the selection back up to 2000 times. On a J700 the controller sometimes dropped that write while it woke: every read gave the page tipd had used last (0x20). The cut then gave up after about 730 ms with "the stop failed: -110", and the debug link stayed up through the sleep. While the readback is neither the page nor a selection in progress (page | 0x80), send WAKEUP and the select again every 20 reads, as tipd's own wake does with its WAKEUP. Signed-off-by: Diljit Singh <hey@djdev.me>
Signed-off-by: Diljit Singh <hey@djdev.me>
…elect Brings in #1208's aop-bootargs host test fix. No conflicts. Signed-off-by: Diljit Singh <hey@djdev.me>
Signed-off-by: Diljit Singh <hey@djdev.me>
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #1285.
Cause. The sleep's debug-link cut selects a page of the debug port's controller (sn201202x 1-0c) with a single write, then reads the selection back 2000 times. That write is sometimes dropped while the controller wakes. Every read then returns the page tipd used last (0x20), the cut gives up with
debug link: the stop failed: -110, and the link stays up through the sleep. Seen on the J700 with #1208 merged (kit dlg, 1 of 18 cuts on a rerun:select 0x8 ... read 0x20 after 2000).Fix. While the readback is neither the page nor a selection in progress (page | 0x80), send WAKEUP and the select again every 20 reads.
Hardware (J700).
-110;read 0x20 at 19, sent again, then the cut completed and the contract came back.-110.-110remains, from a different step: the S3 notice the cut sends after its reset didn't complete in time. The link was already cut and that sleep was fine.🤖 Generated with Claude Code