Skip to content

t8140: send the debug port's page select again until it takes - #1310

Closed
DjDeveloperr wants to merge 6 commits into
fix/t8140-debug-link-rearmfrom
fix/t8140-debug-port-select
Closed

DjDeveloperr wants to merge 6 commits into
fix/t8140-debug-link-rearmfrom
fix/t8140-debug-port-select

Conversation

@DjDeveloperr

Copy link
Copy Markdown
Contributor

Stacked on #1285.

Cause. The sleep's debug-link cut selects a page of the debug port's controller (sn201202x 1-0c) with a single write, then reads the selection back 2000 times. That write is sometimes dropped while the controller wakes. Every read then returns the page tipd used last (0x20), the cut gives up with debug link: the stop failed: -110, and the link stays up through the sleep. Seen on the J700 with #1208 merged (kit dlg, 1 of 18 cuts on a rerun: select 0x8 ... read 0x20 after 2000).

Fix. While the readback is neither the page nor a selection in progress (page | 0x80), send WAKEUP and the select again every 20 reads.

Hardware (J700).

🤖 Generated with Claude Code

…l it takes

The cut selects a register page of the debug port's controller with one
write, then reads the selection back up to 2000 times. On a J700 the
controller sometimes dropped that write while it woke: every read gave
the page tipd had used last (0x20). The cut then gave up after about
730 ms with "the stop failed: -110", and the debug link stayed up
through the sleep.

While the readback is neither the page nor a selection in progress
(page | 0x80), send WAKEUP and the select again every 20 reads, as
tipd's own wake does with its WAKEUP.

Signed-off-by: Diljit Singh <hey@djdev.me>
Signed-off-by: Diljit Singh <hey@djdev.me>
…elect

Brings in integration/aurora 15f88e1 through #1208. No conflicts.

Signed-off-by: Diljit Singh <hey@djdev.me>
…elect

Brings in #1208's aop-bootargs host test fix. No conflicts.

Signed-off-by: Diljit Singh <hey@djdev.me>
Signed-off-by: Diljit Singh <hey@djdev.me>
…elect

Brings in integration/aurora ac11649 (#1311, PCIe multi power domain
support) through #1208. No conflicts.

Signed-off-by: Diljit Singh <hey@djdev.me>
@DjDeveloperr

Copy link
Copy Markdown
Contributor Author

Superseded by #1445 (merged as 2b05915); its changes are in integration/aurora. The page-select retry is in sleep_hpm_select() in drivers/soc/apple/sleep.c.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant