Repository navigation
arm64: dts: apple: t6041-j616c: enable the ISP - #1368
Merged
RyanTheTide merged 1 commit intoNov 10, 2026
Merged
RyanTheTide merged 1 commit into
RyanTheTide merged 1 commit into
Conversation
iBoot places the ISP firmware differently on each boot here, so the J616s placement does not hold. The loader fills the firmware regions from the ADT, so add them as placeholders with the J616s addresses and enable the ISP: its alias, which aura needs to open the DAPF, the firmware regions and heap, the node with its platform ID, camera connection scheme and two IMX958 presets (the 720p one keeps the full frame, as aurora-silicon#1005 did for the other boards), and the three DARTs. This goes in the J616c board file, not in t6041-j614c-j616c.dtsi: there is no J614c ADT yet, so its camera setup is unchecked. Signed-off-by: AxxzyWasTaken <axxzytte@gmail.com>
RyanTheTide
merged commit Nov 10, 2026
e59bcc8
into
aurora-silicon:integration/aurora
2 checks passed
This was referenced Nov 11, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces #931, rebased onto current
integration/auroraas requested. The ISP change is now one commit with a Signed-off-by, on top of the sharedt6041-j614c-j616c.dtsi.Enables the ISP on the J616C. The J614c/J616c board body (
t6041-j614c-j616c.dtsi) doesn't includet604x-j614-j616.dtsi, which holds the ISP setup for the other boards, so this adds it tot6041-j616c.dts:ispaliasisp-firmware-text,isp-firmware-dataandisp-heapunder/reserved-memory&ispwith the memory regions, platform ID, camera connection scheme and the two IMX958 presets&isp_dart0,&isp_dart1and&isp_dart2It goes in the J616c board file, not the shared one: there is no J614c ADT yet, so the J614c's camera setup is unchecked and its ISP stays off.
iBoot places the ISP firmware differently on each boot here. The two firmware regions are placeholders with the J616s addresses, and the loader fills them from the ADT.
Needs aura#71, now merged. Without it the regions keep the J616s addresses, and the driver fails its firmware boot and gives up.
Testing
t6041-j616c.dtbbuilds onintegration/aurorace2060e atW=1with no new warnings. Against the dtb from ce2060e, the decompiled tree only gains the alias, the three reserved-memory nodes, the ISP properties and presets, andokayon the ISP and its three DARTs.t6041-j614c.dtbis unaffected: the shared file isn't touched.