Skip to content

arm64: dts: apple: t6041-j616c: enable the ISP - #1368

Merged
RyanTheTide merged 1 commit into
aurora-silicon:integration/aurorafrom
AxxzyWasTaken:j616c-dt-camera-v2
Nov 10, 2026
Merged

RyanTheTide merged 1 commit into
aurora-silicon:integration/aurorafrom
AxxzyWasTaken:j616c-dt-camera-v2

Conversation

@AxxzyWasTaken

Copy link
Copy Markdown
Contributor

Replaces #931, rebased onto current integration/aurora as requested. The ISP change is now one commit with a Signed-off-by, on top of the shared t6041-j614c-j616c.dtsi.

Enables the ISP on the J616C. The J614c/J616c board body (t6041-j614c-j616c.dtsi) doesn't include t604x-j614-j616.dtsi, which holds the ISP setup for the other boards, so this adds it to t6041-j616c.dts:

  • the isp alias
  • isp-firmware-text, isp-firmware-data and isp-heap under /reserved-memory
  • &isp with the memory regions, platform ID, camera connection scheme and the two IMX958 presets
  • &isp_dart0, &isp_dart1 and &isp_dart2

It goes in the J616c board file, not the shared one: there is no J614c ADT yet, so the J614c's camera setup is unchecked and its ISP stays off.

iBoot places the ISP firmware differently on each boot here. The two firmware regions are placeholders with the J616s addresses, and the loader fills them from the ADT.

Needs aura#71, now merged. Without it the regions keep the J616s addresses, and the driver fails its firmware boot and gives up.

Testing

  • t6041-j616c.dtb builds on integration/aurora ce2060e at W=1 with no new warnings. Against the dtb from ce2060e, the decompiled tree only gains the alias, the three reserved-memory nodes, the ISP properties and presets, and okay on the ISP and its three DARTs.
  • t6041-j614c.dtb is unaffected: the shared file isn't touched.
  • This tree has not been booted.
  • The 720p preset uses the crop from arm64: dts: apple: t604x-j614-j616: scale the 720p camera preset #1005. The same crop runs on my Mac, from a separate tree.
  • An earlier version of this change, on the previous DT stack, booted on a 32-core J616C with aura#71 on a 7.3 kernel. The camera came up as FaceTime HD Camera at 1920x1080, and a 6-second capture gave a live image, checked by its brightness only.

iBoot places the ISP firmware differently on each boot here, so the J616s
placement does not hold. The loader fills the firmware regions from the
ADT, so add them as placeholders with the J616s addresses and enable the
ISP: its alias, which aura needs to open the DAPF, the firmware regions
and heap, the node with its platform ID, camera connection scheme and two
IMX958 presets (the 720p one keeps the full frame, as aurora-silicon#1005 did for the
other boards), and the three DARTs.

This goes in the J616c board file, not in t6041-j614c-j616c.dtsi: there
is no J614c ADT yet, so its camera setup is unchecked.

Signed-off-by: AxxzyWasTaken <axxzytte@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants